r66023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66022‎ | r66023 | r66024 >
Date:15:12, 7 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Applied patch of Benjamin Langguth as seen in bug 23431
Modified paths:
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFunctions.js (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenStreetMap/SM_OSMFunctions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFunctions.js
@@ -92,7 +92,7 @@
9393 function removeMarkers(markerLayer) {
9494 var markerCollection = markerLayer.markers;
9595
96 - for (i in markerCollection) {
 96+ for (var i = 0; i < markerCollection.length; i++) {
9797 markerLayer.removeMarker(markerCollection[i]);
9898 }
9999 }
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/Services/OpenStreetMap/SM_OSMFunctions.js
@@ -93,7 +93,7 @@
9494 function removeOSMMarkers(markerLayer) {
9595 var markerCollection = markerLayer.markers;
9696
97 - for (i in markerCollection) {
 97+ for (var i=0; i < markerCollection.length; i++) {
9898 markerLayer.removeMarker(markerCollection[i]);
9999 }
100100 }
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66022Applied patch of Benjamin Langguth as seen in bug 23431jeroendedauw15:12, 7 May 2010

Status & tagging log