r65986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65985‎ | r65986 | r65987 >
Date:15:07, 6 May 2010
Author:yaron
Status:deferred
Tags:
Comment:
Fix for empty query string values
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -634,7 +634,7 @@
635635 is_array( $template_instance_query_values ) &&
636636 array_key_exists( $escaped_field_name, $template_instance_query_values ) ) {
637637 $field_query_val = $template_instance_query_values[$escaped_field_name];
638 - if ( $form_submitted || ( $field_query_val != '' && ! is_array( $field_query_val ) ) ) {
 638+ if ( $form_submitted || ( ! is_null( $field_query_val ) && ! is_array( $field_query_val ) ) ) {
639639 $cur_value = $field_query_val;
640640 }
641641 } else

Status & tagging log