r65971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65970‎ | r65971 | r65972 >
Date:23:25, 5 May 2010
Author:demon
Status:ok
Tags:
Comment:
Pass correct titles to DifferenceEngine rather than relying on $wgTitle
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/Oversight/HideRevision_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Oversight/HideRevision_body.php
@@ -565,7 +565,7 @@
566566 }
567567 $ntext = strval( $rev->getText( Revision::FOR_THIS_USER ) );
568568
569 - $diffEngine = new DifferenceEngine();
 569+ $diffEngine = new DifferenceEngine( $rev->mTitle );
570570 $diffEngine->showDiffStyle();
571571 $wgOut->addHTML(
572572 "<ul>" .
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -639,7 +639,7 @@
640640 return false; // deleted revision or something?
641641 # Build diff at the top of the page
642642 if ( strcmp( $oText, $nText ) !== 0 ) {
643 - $diffEngine = new DifferenceEngine();
 643+ $diffEngine = new DifferenceEngine( $this->article->getTitle() );
644644 $diffEngine->showDiffStyle();
645645 $n = $this->article->getTitle()->countRevisionsBetween( $srev->getRevId(), $latest );
646646 if ( $n ) {
@@ -816,7 +816,7 @@
817817 $text = $this->article->getSection( $text, $section );
818818 }
819819 if ( $text !== false && strcmp( $text, $editPage->textbox1 ) !== 0 ) {
820 - $diffEngine = new DifferenceEngine();
 820+ $diffEngine = new DifferenceEngine( $this->article->getTitle() );
821821 $diffEngine->showDiffStyle();
822822 $diffHtml =
823823 wfMsgExt( 'review-edit-diff', 'parseinline' ) . ' ' .

Status & tagging log