r65935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65934‎ | r65935 | r65936 >
Date:02:24, 5 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Escaping bugfix
Modified paths:
  • /trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php
@@ -126,10 +126,8 @@
127127 if ( $this->isValid() && ( $linked !== null ) && ( $linked !== false ) ) {
128128 SMWOutputs::requireHeadItem( SMW_HEADER_TOOLTIP );
129129 return '<span class="smwttinline">' . htmlspecialchars( $this->m_caption ) . '<span class="smwttcontent">' .
130 - htmlspecialchars (
131 - wfMsgForContent( 'maps-latitude' ) . ' ' . $this->mCoordinateSet['lat'] . '<br />' .
132 - wfMsgForContent( 'maps-longitude' ) . ' ' . $this->mCoordinateSet['lon']
133 - ) .
 130+ htmlspecialchars ( wfMsgForContent( 'maps-latitude' ) . ' ' . $this->mCoordinateSet['lat'] ) . '<br />' .
 131+ htmlspecialchars ( wfMsgForContent( 'maps-longitude' ) . ' ' . $this->mCoordinateSet['lon'] ) .
134132 '</span></span>';
135133 } else {
136134 return htmlspecialchars( $this->m_caption );

Status & tagging log