r65930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65929‎ | r65930 | r65931 >
Date:01:47, 5 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r65928
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php
@@ -63,12 +63,12 @@
6464
6565 $manager = new ValidatorManager();
6666
67 - $result = $manager->manageParameters( $mapProperties, $parameterInfo );
 67+ $showMap = $manager->manageParameters( $mapProperties, $parameterInfo );
6868
69 - $showMap = $result !== false;
 69+ if ( $showMap ) {
 70+ $this->setMapProperties( $manager->getParameters( false ), __CLASS__ );
 71+ }
7072
71 - if ( $showMap ) $this->setMapProperties( $result, __CLASS__ );
72 -
7373 $this->errorList = $manager->getErrorList();
7474
7575 return $showMap;
Index: trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php
@@ -120,12 +120,12 @@
121121
122122 $manager = new ValidatorManager();
123123
124 - $result = $manager->manageParameters( $mapProperties, $parameterInfo );
 124+ $showMap = $manager->manageParameters( $mapProperties, $parameterInfo );
125125
126 - $showMap = $result !== false;
 126+ if ( $showMap ) {
 127+ $this->setMapProperties( $manager->getParameters( false ), __CLASS__ );
 128+ }
127129
128 - if ( $showMap ) $this->setMapProperties( $result, __CLASS__ );
129 -
130130 $this->errorList = $manager->getErrorList();
131131
132132 return $showMap;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65928Changes for 0.3 - improved validation manager classjeroendedauw01:47, 5 May 2010

Status & tagging log