r65909 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65908‎ | r65909 | r65910 >
Date:18:47, 4 May 2010
Author:kipcool
Status:deferred
Tags:
Comment:
faster ( removed a where clause which is in fact not needed )
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialOWStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/SpecialOWStatistics.php
@@ -75,7 +75,6 @@
7676 $sql .= " FROM {$dc}_expression, {$dc}_syntrans" ;
7777 $sql .= " WHERE {$dc}_expression.expression_id = {$dc}_syntrans.expression_id " ;
7878 $sql .= " AND {$dc}_syntrans.remove_transaction_id IS NULL " ;
79 - $sql .= " AND {$dc}_expression.remove_transaction_id IS NULL " ;
8079 $sql .= " group by language_id " ;
8180
8281 $queryResult = $dbr->query( $sql );
@@ -169,7 +168,6 @@
170169 $sql .= " FROM {$dc}_expression, {$dc}_syntrans" ;
171170 $sql .= " WHERE {$dc}_expression.expression_id = {$dc}_syntrans.expression_id " ;
172171 $sql .= " AND {$dc}_syntrans.remove_transaction_id IS NULL " ;
173 - $sql .= " AND {$dc}_expression.remove_transaction_id IS NULL " ;
174172 $sql .= " group by language_id " ;
175173
176174 $queryResult = $dbr->query( $sql );
@@ -216,7 +214,6 @@
217215 $sql .= " FROM {$dc}_expression, {$dc}_syntrans" ;
218216 $sql .= " WHERE {$dc}_expression.expression_id = {$dc}_syntrans.expression_id " ;
219217 $sql .= " AND {$dc}_syntrans.remove_transaction_id IS NULL " ;
220 - $sql .= " AND {$dc}_expression.remove_transaction_id IS NULL " ;
221218 $sql .= " group by language_id " ;
222219
223220 $queryResult = $dbr->query( $sql );

Status & tagging log