r65863 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65862‎ | r65863 | r65864 >
Date:16:01, 3 May 2010
Author:avar
Status:reverted
Tags:
Comment:
Note if we can't check the latest MediaWiki release from mediawiki.org

Previously we just silently proceeded, now there's a warning with a
link to the URL. Someone installing MediaWiki offline or behind some
draconian firewall will know about the issue.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/Installer.i18n.php
@@ -70,6 +70,7 @@
7171 'config-env-php' => 'PHP $1 installed.',
7272 'config-env-latest-ok' => 'You are installing the latest version of Mediawiki.',
7373 'config-env-latest-new' => "'''Note:''' You are installing a development version of Mediawiki.",
 74+ 'config-env-latest-can-not-check' => "'''Note:''' We were unable to retrieve information about the latest MediaWiki release (from [$1]).",
7475 'config-env-latest-old' => "'''Warning:''' You are installing an outdated version of Mediawiki.",
7576 'config-env-latest-help' => 'You are installing version $1, but the latest version is $2.
7677 You are advised to use the latest release, which can be downloaded from [http://www.mediawiki.org/wiki/Download mediawiki.org]',
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -354,8 +354,10 @@
355355 /** Check if we're installing the latest version */
356356 function envLatestVersion() {
357357 global $wgVersion;
358 - $latestInfo = Http::get( 'http://www.mediawiki.org/w/api.php?action=mwreleases&format=php' );
 358+ $latestInfoUrl = 'http://www.mediawiki.org/w/api.php?action=mwreleases&format=php';
 359+ $latestInfo = Http::get( $latestInfoUrl );
359360 if( !$latestInfo ) {
 361+ $this->showMessage( 'config-env-latest-can-not-check', $latestInfoUrl );
360362 return;
361363 }
362364 $latestInfo = unserialize($latestInfo);

Follow-up revisions

RevisionCommit summaryAuthorDate
r77883Remove "checking for latest version" feature from the new installer. Original...demon15:32, 6 December 2010

Status & tagging log