r65840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r65839‎ | r65840 | r65841 >
Date:08:48, 3 May 2010
Author:werdna
Status:ok
Tags:
Comment:
Uncomment gb_expiry condition in SpecialGlobalBlockList.php which has been inexplicably commented-out since GlobalBlocking was first committed two years ago.
Modified paths:
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php
——@@ -207,7 +207,7 @@
208208
209209 function getQueryInfo() {
210210 $conds = $this->mConds;
211 - #$conds[] = 'gb_expiry>' . $this->mDb->addQuotes( $this->mDb->timestamp() );
 211+ $conds[] = 'gb_expiry>' . $this->mDb->addQuotes( $this->mDb->timestamp() );
212212 return array(
213213 'tables' => 'globalblocks',
214214 'fields' => '*',

Status & tagging log