r65823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65822‎ | r65823 | r65824 >
Date:01:31, 3 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed security issues
Modified paths:
  • /trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php
@@ -82,12 +82,16 @@
8383 } else {
8484 $wgOut->setPageTitle( wfMsg( 'storyboard-submissionincomplete' ) );
8585
86 - $wgOut->addWikiMsg( 'storyboard-alreadyexists', $title, $wgTitle->getFullURL() );
 86+ $wgOut->addWikiMsg( 'storyboard-alreadyexists', $title,$wgTitle->getFullURL() );
8787
8888 // Let's not give a null link to people with no JS.
8989 // TODO: change this to the last page somehow
90 - $fallBackUrl = Title::newMainPage()->getFullURL();
91 - $wgOut->addHtml( "<a href='$fallBackUrl' onclick='history.go(-1); return false;'>" . wfMsg( 'storyboard-changetitle' ) . '</a>' );
 90+ htmlspecialchars( $fallBackUrl = Title::newMainPage()->getFullURL() );
 91+ $wgOut->addHtml(
 92+ "<a href=\"$fallBackUrl\" onclick='history.go(-1); return false;'>" .
 93+ htmlspecialchars( wfMsg( 'storyboard-changetitle' ) ) .
 94+ '</a>'
 95+ );
9296 }
9397 }
9498

Status & tagging log