r65817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65816‎ | r65817 | r65818 >
Date:19:47, 2 May 2010
Author:ialex
Status:deferred
Tags:
Comment:
* (bug 23379) Settings based on radio button now longer throw errors if nothing is selected
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/specials/ConfigurationPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -2,7 +2,9 @@
33 through translatewiki.net and are not listed here.
44
55 0.15.23 - 2 May 2010
6 - Added $wgLocalStylePath and $wgVectorShowVariantName.
 6+ * (bug 23379) Settings based on radio button now longer throw errors if
 7+ nothing is selected
 8+ * Added $wgLocalStylePath and $wgVectorShowVariantName.
79
810 0.15.22 - 25 April 2010
911 Added $wgAllowImageTag and $wgLogAutocreatedAccounts.
Index: trunk/extensions/Configure/specials/ConfigurationPage.php
@@ -715,7 +715,7 @@
716716 default:
717717 if ( is_array( $type ) ) {
718718 $val = $wgRequest->getVal( 'wp' . $name );
719 - if ( !array_key_exists( $val, $type ) ) {
 719+ if ( !array_key_exists( $val, $type ) && $val !== null ) {
720720 $perm = implode( ', ', $type );
721721 throw new MWException( "Value for \$$name setting is not in permitted (given: $val, permitted: $perm)" );
722722 }

Status & tagging log