r65752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65751‎ | r65752 | r65753 >
Date:17:47, 1 May 2010
Author:kipcool
Status:deferred
Tags:
Comment:
urlencode only for "&" (otherwise, links with "/" were broken)
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/type.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/type.php
@@ -27,8 +27,8 @@
2828
2929 global $wgArticlePath;
3030
31 - $titleNoSpace = str_replace( " ", "_", $title ) ;
32 - $url = str_replace( "$1", $nameSpace . ':' . urlencode( $titleNoSpace ), $wgArticlePath );
 31+ $myTitle = str_replace( "&", urlencode("&") , $title ) ;
 32+ $url = str_replace( "$1", $nameSpace . ':' . $myTitle , $wgArticlePath );
3333
3434 if ( $usedc ) {
3535 $dc = wdGetDataSetContext();

Status & tagging log