r65676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65675‎ | r65676 | r65677 >
Date:23:41, 29 April 2010
Author:neilk
Status:deferred
Tags:
Comment:
misc layout issues
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js
@@ -967,7 +967,7 @@
968968
969969 _this.errorDiv = $j( '<div class="mwe-upwiz-details-error"></div>' );
970970
971 - _this.dataDiv = $j( '<div class="mwe-upwiz-details-data"></div>' );
 971+ _this.dataDiv = $j( '<div class="mwe-upwiz-data"></div>' );
972972
973973 // descriptions
974974 _this.descriptionsDiv = $j( '<div class="mwe-upwiz-details-descriptions mwe-upwiz-details-input"></div>' );
@@ -1838,11 +1838,11 @@
18391839 + '</div>'
18401840 + '<div class="mwe-upwiz-tabdiv" id="mwe-upwiz-tabdiv-details">'
18411841 + '<div id="mwe-upwiz-macro">'
 1842+ + '<div id="mwe-upwiz-macro-progress" class="ui-helper-clearfix"></div>'
18421843 + '<div id="mwe-upwiz-macro-choice">'
18431844 + '<div>' + gM( 'mwe-upwiz-intro-details' ) + '</div>'
18441845 + '<div id="mwe-upwiz-macro-deeds"></div>'
18451846 + '</div>'
1846 - + '<div id="mwe-upwiz-macro-progress"></div>'
18471847 + '<div id="mwe-upwiz-macro-files"></div>'
18481848 + '<div class="mwe-upwiz-macro-edit-submit"></div>' // button added below
18491849 + '</div>'
@@ -2218,7 +2218,6 @@
22192219 },
22202220
22212221
2222 - // might as well hardcode more of this?
22232222 prefillThanksPage: function() {
22242223 var _this = this;
22252224
@@ -2226,11 +2225,11 @@
22272226 var width = mw.getConfig( 'thumbnailWidth' );
22282227
22292228 $j.each( _this.uploads, function(i, upload) {
2230 - var thanksDiv = $j( '<div class="mwe-thanks ui-helper-clearfix" />' );
2231 - var thumbnailDiv = $j( '<div></div>' ).addClass( 'mwe-upwiz-links-thumbnail' );
 2229+ var thanksDiv = $j( '<div class="mwe-upwiz-thanks ui-helper-clearfix" />' );
 2230+ var thumbnailDiv = $j( '<div></div>' ).addClass( 'mwe-upwiz-thumbnail' );
22322231 thanksDiv.append( thumbnailDiv );
22332232
2234 - /* this is copied code, evil */
 2233+ /* XXX this is copied code, evil */
22352234 var callback = function( thumbnail ) {
22362235 // side effect: will replace thumbnail's loadingSpinner
22372236 thumbnailDiv.html(
@@ -2253,8 +2252,7 @@
22542253 var thumbWikiText = "[[" + thumbTitle + "|thumb]]";
22552254
22562255 thanksDiv.append(
2257 - $j( '<div class="mwe-upwiz-info-file"></div>' )
2258 - .addClass( 'mwe-upwiz-thanks-links' )
 2256+ $j( '<div class="mwe-upwiz-data"></div>' )
22592257 .append(
22602258 $j('<p/>').append(
22612259 gM( 'mwe-upwiz-thanks-link',
@@ -2268,13 +2266,17 @@
22692267 gM( 'mwe-upwiz-thanks-wikitext' ),
22702268 $j( '<br />' ),
22712269 $j( '<textarea class="mwe-long-textarea" rows="1"/>' )
 2270+ .growTextArea()
22722271 .append( thumbWikiText )
 2272+ .trigger( 'change' ) // to make it grow to fit
22732273 ),
22742274 $j('<p/>').append(
22752275 gM( 'mwe-upwiz-thanks-url' ),
22762276 $j( '<br />' ),
22772277 $j( '<textarea class="mwe-long-textarea" rows="1"/>' )
 2278+ .growTextArea()
22782279 .append( upload.imageinfo.descriptionurl )
 2280+ .trigger( 'change' ) // to make it grow to fit
22792281 )
22802282 )
22812283 );
Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css
@@ -268,7 +268,7 @@
269269 margin-right: 12px;
270270 }
271271
272 -.mwe-upwiz-details-data {
 272+.mwe-upwiz-data {
273273 float: left;
274274 }
275275
@@ -399,6 +399,8 @@
400400 width: 280px;
401401 }
402402
 403+
 404+
403405 .mwe-upwiz-details-label {
404406 width: 100px;
405407 float: left;
@@ -473,4 +475,3 @@
474476 margin-top: 5px;
475477 }
476478
477 -

Status & tagging log