r65674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65673‎ | r65674 | r65675 >
Date:22:02, 29 April 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r65672. FIXED.
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -1215,7 +1215,6 @@
12161216 }
12171217 }
12181218
1219 - # FIXME: Check for errors
12201219 print "<li>Creating tables...";
12211220 if ($conf->DBtype == 'mysql') {
12221221 $res = $wgDatabase->sourceFile( "../maintenance/tables.sql" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65672Actually check sourceFile for failure, showing the error message in the install....platonides21:49, 29 April 2010

Status & tagging log