r65669 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65668‎ | r65669 | r65670 >
Date:20:57, 29 April 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added dependency definitions
Modified paths:
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMaps.php
@@ -77,7 +77,8 @@
7878 'in_array' => $allowedTypes
7979 ),
8080 'default' => $egMapsYahooMapsType, // FIXME: default value should not be used when not present in types parameter.
81 - 'output-type' => 'ymaptype'
 81+ 'output-type' => 'ymaptype',
 82+ 'dependencies' => array( 'types' )
8283 ),
8384 'types' => array (
8485 'type' => array( 'string', 'list' ),
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php
@@ -79,7 +79,8 @@
8080 'in_array' => $allowedTypes
8181 ),
8282 'default' => $egMapsGoogleMapsType, // FIXME: default value should not be used when not present in types parameter.
83 - 'output-type' => 'gmaptype'
 83+ 'output-type' => 'gmaptype',
 84+ 'dependencies' => array( 'types' )
8485 ),
8586 'types' => array(
8687 'type' => array( 'string', 'list' ),

Status & tagging log