r65663 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65662‎ | r65663 | r65664 >
Date:17:57, 29 April 2010
Author:neilk
Status:deferred
Tags:
Comment:
thanks page layout fixes
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js
@@ -61,8 +61,8 @@
6262 "mwe-upwiz-macro-edit": "Update descriptions",
6363 "mwe-upwiz-thanks-intro": "Thanks for uploading your works! You can now use your files on a Wikipedia article or link to them from elsewhere on the web.",
6464 "mwe-upwiz-thanks-link": "This file is now available at <b><tt>$1</tt></b>.",
65 - "mwe-upwiz-thanks-wikitext": "To use it in a Wikipedia article, copy this text into an article: ",
66 - "mwe-upwiz-thanks-url": "To link to it in HTML, copy this HTML code: ",
 65+ "mwe-upwiz-thanks-wikitext": "<b>To use it in a Wikipedia article</b>, copy this text into an article: ",
 66+ "mwe-upwiz-thanks-url": "<b>To link to it in HTML</b>, copy this HTML code: ",
6767
6868 "mwe-upwiz-upload-error-bad-filename-extension": "This wiki does not accept filenames with the extension \"$1\".",
6969 "mwe-upwiz-upload-error-duplicate": "This file was previously uploaded to this wiki.",
@@ -961,7 +961,7 @@
962962
963963 _this.descriptions = [];
964964
965 - _this.div = $j( '<div class="mwe-upwiz-details-file"></div>' );
 965+ _this.div = $j( '<div class="mwe-upwiz-info-file"></div>' );
966966
967967 _this.thumbnailDiv = $j( '<div class="mwe-upwiz-thumbnail"></div>' );
968968
@@ -1840,14 +1840,10 @@
18411841 + '<div id="mwe-upwiz-macro">'
18421842 + '<div id="mwe-upwiz-macro-choice">'
18431843 + '<div>' + gM( 'mwe-upwiz-intro-details' ) + '</div>'
1844 - + '<div id="mwe-upwiz-macro-deeds" />'
 1844+ + '<div id="mwe-upwiz-macro-deeds"></div>'
18451845 + '</div>'
1846 - + '<div id="mwe-upwiz-macro-edit">'
1847 - + '<div>'
1848 - //+ '<p>' + gM( 'mwe-upwiz-macro-edit-intro' ) + '</p>'
1849 - + '</div>'
18501846 + '<div id="mwe-upwiz-macro-progress"></div>'
1851 - + '<div id="mwe-upwiz-macro-files"></div>'
 1847+ + '<div id="mwe-upwiz-macro-files"></div>'
18521848 + '<div class="mwe-upwiz-macro-edit-submit"></div>' // button added below
18531849 + '</div>'
18541850 + '</div>'
@@ -2226,12 +2222,11 @@
22272223 prefillThanksPage: function() {
22282224 var _this = this;
22292225
2230 - var thanksDiv = $j( '#mwe-upwiz-thanks' );
2231 -
2232 - thanksDiv.append( $j( '<p>' ).append( gM( 'mwe-upwiz-thanks-intro' ) ) );
 2226+ $j( '#mwe-upwiz-thanks' ).append( $j( '<p>' ).append( gM( 'mwe-upwiz-thanks-intro' ) ) );
22332227 var width = mw.getConfig( 'thumbnailWidth' );
22342228
22352229 $j.each( _this.uploads, function(i, upload) {
 2230+ var thanksDiv = $j( '<div class="mwe-thanks ui-helper-clearfix" />' );
22362231 var thumbnailDiv = $j( '<div></div>' ).addClass( 'mwe-upwiz-links-thumbnail' );
22372232 thanksDiv.append( thumbnailDiv );
22382233
@@ -2255,29 +2250,36 @@
22562251 /* end evil copied code */
22572252
22582253 var thumbTitle = upload.title.replace(/^File/, 'Image'); // XXX is this really necessary?
2259 - var thumbWikiText = "[[" + thumbTitle + "|thumb|right]]";
 2254+ var thumbWikiText = "[[" + thumbTitle + "|thumb]]";
22602255
22612256 thanksDiv.append(
2262 - $j( '<div></div>' )
 2257+ $j( '<div class="mwe-upwiz-info-file"></div>' )
22632258 .addClass( 'mwe-upwiz-thanks-links' )
2264 - .append( $j('<p/>')
2265 - .append( gM( 'mwe-upwiz-thanks-link',
2266 - $j( '<a />' )
2267 - .attr( { target: '_new', href: upload.imageinfo.descriptionurl } )
2268 - .text( upload.title ) ) ) )
2269 - .append( $j('<p/>')
2270 - .append( gM( 'mwe-upwiz-thanks-wikitext' ),
2271 - $j( '<textarea></textarea>' )
2272 - .addClass( 'mwe-thanks-input-textarea' )
2273 - .append( thumbWikiText ) ) )
2274 - .append( $j('<p/>')
2275 - .append( gM( 'mwe-upwiz-thanks-url' ),
2276 - $j( '<input />' )
2277 - .addClass( 'mwe-thanks-input' )
2278 - .attr( { type: 'text', value: upload.imageinfo.descriptionurl } ) ) )
2279 -
 2259+ .append(
 2260+ $j('<p/>').append(
 2261+ gM( 'mwe-upwiz-thanks-link',
 2262+ $j( '<a />' )
 2263+ .attr( { target: '_new',
 2264+ href: upload.imageinfo.descriptionurl } )
 2265+ .text( upload.title )
 2266+ )
 2267+ ),
 2268+ $j('<p/>').append(
 2269+ gM( 'mwe-upwiz-thanks-wikitext' ),
 2270+ $j( '<br />' ),
 2271+ $j( '<textarea class="mwe-long-textarea" rows="1"/>' )
 2272+ .append( thumbWikiText )
 2273+ ),
 2274+ $j('<p/>').append(
 2275+ gM( 'mwe-upwiz-thanks-url' ),
 2276+ $j( '<br />' ),
 2277+ $j( '<textarea class="mwe-long-textarea" rows="1"/>' )
 2278+ .append( upload.imageinfo.descriptionurl )
 2279+ )
 2280+ )
22802281 );
22812282
 2283+ $j( '#mwe-upwiz-thanks' ).append( thanksDiv );
22822284 } );
22832285 },
22842286
Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css
@@ -353,7 +353,7 @@
354354 #mwe-upwiz-macro-files {
355355 margin-top: 12px;
356356 }
357 -.mwe-upwiz-details-file {
 357+.mwe-upwiz-info-file {
358358 border-bottom: 1px solid #e0e0e0;
359359 margin-bottom: 12px;
360360 padding-bottom: 12px;
@@ -474,4 +474,3 @@
475475 }
476476
477477
478 -

Follow-up revisions

RevisionCommit summaryAuthorDate
r65959Merge Vector and UsabilityInitiative fixes from trunk: r64724, r65064, r65379...catrope19:03, 5 May 2010

Status & tagging log