r65661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r65660‎ | r65661 | r65662 >
Date:17:49, 29 April 2010
Author:dale
Status:ok
Tags:
Comment:
* follow up to r65660 added check for wgWikiEditorEnabledModules.addMediaWizard
In usability Javascript system module loaders are included regardless of whether they are enabled or not .. ( they could really use a script-loader :P )
Modified paths:
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/AddMediaWizard/AddMediaWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/AddMediaWizard/AddMediaWizard.js
——@@ -1,10 +1,11 @@
22
33 /* JavaScript for AddMediaWizard gadget */
 4+if ( wgWikiEditorEnabledModules.addMediaWizard ) {
 5+ if( typeof mwAddMediaConfig == 'undefined'){
 6+ mwAddMediaConfig = {};
 7+ }
 8+ mwAddMediaConfig['enabled_providers'] = [ 'wiki_commons', 'upload' ];
49
5 -if( typeof mwAddMediaConfig == 'undefined'){
6 - mwAddMediaConfig = {};
 10+ // Transclude mwEmbed support
 11+ importScriptURI('http://prototype.wikimedia.org/s-2/js/mwEmbed/remotes/mediaWiki.js?&uselang=' + wgUserLanguage );
712 }
8 -mwAddMediaConfig['enabled_providers'] = [ 'wiki_commons', 'upload' ];
9 -
10 -// Transclude mwEmbed.js
11 -importScriptURI('http://prototype.wikimedia.org/s-2/js/mwEmbed/remotes/mediaWiki.js?&uselang=' + wgUserLanguage );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65660Integrated Michael Dale's patch to add a preference to the Labs section of us...tparscal17:34, 29 April 2010

Status & tagging log