r65655 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65654‎ | r65655 | r65656 >
Date:15:57, 29 April 2010
Author:dale
Status:deferred
Tags:
Comment:
* code comment cleanup
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/jsScriptLoader.php (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/AjaxCategories/mw.AjaxCategories.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/AjaxCategories/mw.AjaxCategories.js
@@ -12,13 +12,11 @@
1313 "ajax-remove-category-error" : "[RemoveErr]"
1414 } );
1515
16 -var defaultAjaxCategoriesOptions = {
17 -
 16+var defaultAjaxCategoriesOptions = {
1817 // The edit mode can be api, or text box.
1918 // When set to api, category changes are saved to the target article page
20 - // when set to textbox category changes are outputed to a text box.
21 - 'editMode' : 'api'
22 -
 19+ // when set to textbox category changes are outputted to a text box.
 20+ 'editMode' : 'api'
2321 }
2422
2523 /**
Index: branches/js2-work/phase3/js/mwEmbed/jsScriptLoader.php
@@ -16,7 +16,7 @@
1717 }
1818 // No cache hit, load stand alone ScriptLoader config
1919
20 - // ( if running as a remote, mediaWiki variables are already included as part of mediaWiki
 20+ // ( if running as a remote, mediaWiki variables / functions are already included as part of mediaWiki )
2121 require_once( realpath( dirname( __FILE__ ) ) . '/includes/noMediaWikiConfig.php' );
2222 $myScriptLoader->doScriptLoader();
2323 }
@@ -42,7 +42,7 @@
4343 // Error msg
4444 var $errorMsg = '';
4545
46 - // Output format is either 'js' or 'css';
 46+ // Output format is either 'js' or 'css' or 'messages' for exclusivly msg text;
4747 var $outputFormat = 'js';
4848
4949 // Debug flag
@@ -414,7 +414,6 @@
415415 * Get the URI of the scriptLoader
416416 */
417417 private function getScriptLoaderUri() {
418 -
419418 // protocol is http or https
420419 $protocol = 'http';
421420 if ($_SERVER['SERVER_PORT'] == 443 || (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on')) {
@@ -694,6 +693,7 @@
695694 // Else just return the key unchanged:
696695 return $langKey;
697696 }
 697+
698698 /**
699699 * Get a file path for a given class
700700 *
@@ -1119,7 +1119,7 @@
11201120 return true;
11211121 }
11221122 /**
1123 - * Checks cache directories and makes the dirs if not present
 1123+ * Checks cache directories and creates the directories if not present
11241124 */
11251125 protected function checkCacheDirs() {
11261126 $mydir2 = substr( $this->filename, 0, strrpos( $this->filename, '/' ) ); # subdirectory level 2

Status & tagging log