r65636 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r65635‎ \| r65636 \| r65637 >
Date:	21:36, 28 April 2010
Author:	siebrand
Status:	deferred
Tags:
Comment:	stylize.php, trailing whitespace removed
Modified paths:	/trunk/extensions/ChangeAuthor/CHANGELOG (modified) (history) /trunk/extensions/ChangeAuthor/ChangeAuthor.body.php (modified) (history) /trunk/extensions/ChangeAuthor/ChangeAuthor.i18n.php (modified) (history) /trunk/extensions/ChangeAuthor/ChangeAuthor.php (modified) (history) /trunk/extensions/ChangeAuthor/LEESMIJ (modified) (history) /trunk/extensions/ChangeAuthor/README (modified) (history)

Diff [purge]

Index: trunk/extensions/ChangeAuthor/CHANGELOG
—	—	@@ -1,2 +1,3 @@
2	2	== Changes since 1.0 ==
3		~~-* Fixed buggy message handling by making ChangeAuthor::loadMessages() the static function it's supposed to be.~~
\ No newline at end of file
	3	+* Fixed buggy message handling by making ChangeAuthor::loadMessages() the static
	4	+ function it's supposed to be.
Index: trunk/extensions/ChangeAuthor/LEESMIJ
—	—	@@ -18,7 +18,7 @@
19	19	Deze extensie maakt het mogelijk om de auteur van een bewerking naderhand te veranderen. Zo kan een verandering door Piet veranderd worden zodat het lijkt alsof Klaas hem gemaakt heeft. Natuurlijk kunnen niet alle gebruikers dit doen, en worden alle veranderingen bijgehouden in een logboek.
20	20
21	21	2. VERANDERAUTEUR DOWNLOADEN
22		~~-U kunt een .tar.gz bestand downloaden op http://www.mediawiki.org/wiki/Special:ExtensionDistributor/ChangeAuthor .~~
	22	+U kunt een .tar.gz bestand downloaden op http://www.mediawiki.org/wiki/Special:ExtensionDistributor/ChangeAuthor .
23	23
24	24	3. INSTALLATIE
25	25	Download de .tar.gz genoemd onder (2.) en pak hem uit in /pad/naar/uw/wiki/extensions . Open dan LocalSettings.php, en voeg de volgende regel toe aan het einde:
—	—	@@ -73,4 +73,4 @@
74	74	VeranderAuteur wordt momenteel beheerd door Roan Kattouw. Indien u vragen hebt, klachten, idee�n voor nieuwe mogelijkheden, een fout gevonden hebt, of een andere reden hebt om contact op te nemen met de beheerder, stuur dan uw e-mails naar roan.kattouw@home.nl en noem "ChangeAuthor" in het onderwerp. In het Nederlands geschreven e-mails zijn ook welkom.
75	75
76	76	9. DANKWOORD
77		~~-VeranderAuteur is geschreven voor de Bokt Wiki <http://www.bokt.nl/wiki/> door Roan Kattouw <roan.kattouw@home.nl>~~
\ No newline at end of file
	77	+VeranderAuteur is geschreven voor de Bokt Wiki <http://www.bokt.nl/wiki/> door Roan Kattouw <roan.kattouw@home.nl>
Index: trunk/extensions/ChangeAuthor/ChangeAuthor.body.php
—	—	@@ -15,8 +15,9 @@
16	16	* Written for the Bokt Wiki <http://www.bokt.nl/wiki/> by Roan Kattouw <roan.kattouw@home.nl>
17	17	* For information how to install and use this extension, see the README file.
18	18	*/
	19	+
19	20	# Alert the user that this is not a valid entry point to MediaWiki if they try to access the extension file directly.
20		~~-if( !defined( 'MEDIAWIKI' ) ) {~~
	21	+if ( !defined( 'MEDIAWIKI' ) ) {
21	22	echo <<<EOT
22	23	To install the ChangeAuthor extension, put the following line in LocalSettings.php:
23	24	require_once( "\$IP/extensions/ChangeAuthor/ChangeAuthor.setup.php" );
—	—	@@ -49,39 +50,39 @@
50	51	$this->setHeaders();
51	52
52	53	// Check permissions
53		~~- if( !$this->userCanExecute( $wgUser ) ) {~~
	54	+ if ( !$this->userCanExecute( $wgUser ) ) {
54	55	$this->displayRestrictionError();
55	56	return;
56	57	}
57	58
58	59	$wgOut->setPageTitle( wfMsg( 'changeauthor-title' ) );
59	60
60		~~- if( !is_null( $par ) ) {~~
	61	+ if ( !is_null( $par ) ) {
61	62	$obj = $this->parseTitleOrRevID( $par );
62		~~- if( $obj instanceof Title ) {~~
63		~~- if( $obj->exists() ) {~~
	63	+ if ( $obj instanceof Title ) {
	64	+ if ( $obj->exists() ) {
64	65	$wgOut->addHTML( $this->buildRevisionList( $obj ) );
65	66	} else {
66	67	$wgOut->addHTML( $this->buildInitialForm( wfMsg( 'changeauthor-nosuchtitle', $obj->getPrefixedText() ) ) );
67	68	}
68	69	return;
69		~~- } elseif( $obj instanceof Revision ) {~~
	70	+ } elseif ( $obj instanceof Revision ) {
70	71	$wgOut->addHTML( $this->buildOneRevForm( $obj ) );
71	72	return;
72	73	}
73	74	}
74	75
75	76	$action = $wgRequest->getVal( 'action' );
76		~~- if( $wgRequest->wasPosted() && $action == 'change' ) {~~
	77	+ if ( $wgRequest->wasPosted() && $action == 'change' ) {
77	78	$arr = $this->parseChangeRequest();
78		~~- if( !is_array( $arr ) ) {~~
	79	+ if ( !is_array( $arr ) ) {
79	80	$targetPage = $wgRequest->getVal( 'targetpage' );
80		~~- if( !is_null( $targetPage ) ) {~~
	81	+ if ( !is_null( $targetPage ) ) {
81	82	$wgOut->addHTML( $this->buildRevisionList( Title::newFromURL( $targetPage ), $arr ) );
82	83	return;
83	84	}
84	85	$targetRev = $wgRequest->getVal( 'targetrev' );
85		~~- if( !is_null( $targetRev ) ) {~~
	86	+ if ( !is_null( $targetRev ) ) {
86	87	$wgOut->addHTML( $this->buildOneRevForm( Revision::newFromId( $targetRev ), $arr ) );
87	88	return;
88	89	}
—	—	@@ -92,15 +93,15 @@
93	94	}
94	95	return;
95	96	}
96		~~- if( $wgRequest->wasPosted() && $action == 'list' ) {~~
	97	+ if ( $wgRequest->wasPosted() && $action == 'list' ) {
97	98	$obj = $this->parseTitleOrRevID( $wgRequest->getVal( 'pagename-revid' ) );
98		~~- if( $obj instanceof Title ) {~~
99		~~- if( $obj->exists() ) {~~
	99	+ if ( $obj instanceof Title ) {
	100	+ if ( $obj->exists() ) {
100	101	$wgOut->addHTML( $this->buildRevisionList( $obj ) );
101	102	} else {
102	103	$wgOut->addHTML( $this->buildInitialForm( wfMsg( 'changeauthor-nosuchtitle', $obj->getPrefixedText() ) ) );
103	104	}
104		~~- } elseif( $obj instanceof Revision ) {~~
	105	+ } elseif ( $obj instanceof Revision ) {
105	106	$wgOut->addHTML( $this->buildOneRevForm( $obj ) );
106	107	}
107	108	return;
—	—	@@ -115,10 +116,10 @@
116	117	*/
117	118	private function parseTitleOrRevID( $str ) {
118	119	$retval = false;
119		~~- if( is_numeric( $str ) ) {~~
	120	+ if ( is_numeric( $str ) ) {
120	121	$retval = Revision::newFromID( $str );
121	122	}
122		~~- if( !$retval ) {~~
	123	+ if ( !$retval ) {
123	124	$retval = Title::newFromURL( $str );
124	125	}
125	126	return $retval;
—	—	@@ -139,7 +140,7 @@
140	141	$retval .= Xml::inputLabel( wfMsg( 'changeauthor-pagename-or-revid' ),
141	142	'pagename-revid', 'pagename-revid' );
142	143	$retval .= Xml::submitButton( wfMsg( 'changeauthor-pagenameform-go' ) );
143		~~- if( $errMsg != '' ) {~~
	144	+ if ( $errMsg != '' ) {
144	145	$retval .= Xml::openElement( 'p' ) . Xml::openElement( 'b' );
145	146	$retval .= Xml::element( 'font', array( 'color' => 'red' ), $errMsg );
146	147	$retval .= Xml::closeElement( 'b' ) . Xml::closeElement( 'p' );
—	—	@@ -161,7 +162,7 @@
162	163	*/
163	164	private function buildRevisionLine( $rev, $title, $isFirst = false, $isLast = false ) {
164	165	// Build curlink
165		~~- if( $isFirst ) {~~
	166	+ if ( $isFirst ) {
166	167	$curLink = wfMsgExt( 'cur', 'escape' );
167	168	} else {
168	169	$curLink = $this->skin->makeKnownLinkObj( $title,
—	—	@@ -169,7 +170,7 @@
170	171	"oldid={$rev->getId()}&diff=cur" );
171	172	}
172	173
173		~~- if( $isLast ) {~~
	174	+ if ( $isLast ) {
174	175	$lastLink = wfMsgExt( 'last', 'escape' );
175	176	} else {
176	177	$lastLink = $this->skin->makeKnownLinkObj( $title,
—	—	@@ -180,7 +181,7 @@
181	182	// Build oldid link
182	183	global $wgLang;
183	184	$date = $wgLang->timeanddate( wfTimestamp( TS_MW, $rev->getTimestamp() ), true );
184		~~- if( $rev->userCan( Revision::DELETED_TEXT ) ) {~~
	185	+ if ( $rev->userCan( Revision::DELETED_TEXT ) ) {
185	186	$link = $this->skin->makeKnownLinkObj( $title, $date, "oldid={$rev->getId()}" );
186	187	} else {
187	188	$link = $date;
—	—	@@ -191,8 +192,8 @@
192	193	$userBox = Xml::input( "user-new-{$rev->getId()}", 50, $wgRequest->getVal( "user-{$rev->getId()}", $rev->getUserText() ) );
193	194	$userText = Xml::hidden( "user-old-{$rev->getId()}", $rev->getUserText() ) . $rev->getUserText();
194	195
195		~~- if( !is_null( $size = $rev->getSize() ) ) {~~
196		~~- if( $size == 0 ) {~~
	196	+ if ( !is_null( $size = $rev->getSize() ) ) {
	197	+ if ( $size == 0 ) {
197	198	$stxt = wfMsgHtml( 'historyempty' );
198	199	} else {
199	200	$stxt = wfMsgHtml( 'historysize', $wgLang->formatNum( $size ) );
—	—	@@ -223,10 +224,10 @@
224	225	array( 'ORDER BY' => 'rev_timestamp DESC', 'LIMIT' => 50 )
225	226	);
226	227	$revs = array();
227		~~- while( ( $r = $dbr->fetchObject( $res ) ) ) {~~
	228	+ while ( ( $r = $dbr->fetchObject( $res ) ) ) {
228	229	$revs[] = new Revision( $r );
229	230	}
230		~~- if( empty( $revs ) ) {~~
	231	+ if ( empty( $revs ) ) {
231	232	// That's very weird
232	233	return wfMsg( 'changeauthor-weirderror' );
233	234	}
—	—	@@ -237,14 +238,14 @@
238	239	$retval .= Xml::hidden( 'targetpage', $title->getPrefixedDBkey() );
239	240	$retval .= Xml::openElement( 'fieldset' );
240	241	$retval .= Xml::element( 'p', array(), wfMsg( 'changeauthor-explanation-multi' ) );
241		~~- $retval .= Xml::inputLabel( wfMsg( 'changeauthor-comment'), 'comment', 'comment', 50);~~
	242	+ $retval .= Xml::inputLabel( wfMsg( 'changeauthor-comment' ), 'comment', 'comment', 50 );
242	243	$retval .= Xml::submitButton(
243	244	wfMsgExt( 'changeauthor-changeauthors-multi',
244	245	array( 'parsemag', 'escape' ),
245	246	count( $revs )
246	247	)
247	248	);
248		~~- if( $errMsg != '' ) {~~
	249	+ if ( $errMsg != '' ) {
249	250	$retval .= Xml::openElement( 'p' ) . Xml::openElement( 'b' );
250	251	$retval .= Xml::element( 'font', array( 'color' => 'red' ), $errMsg );
251	252	$retval .= Xml::closeElement( 'b' ) . Xml::closeElement( 'p' );
—	—	@@ -252,7 +253,7 @@
253	254	$retval .= Xml::element( 'h2', array(), $title->getPrefixedText() );
254	255	$retval .= Xml::openElement( 'ul' );
255	256	$count = count( $revs );
256		~~- foreach( $revs as $i => $rev ) {~~
	257	+ foreach ( $revs as $i => $rev ) {
257	258	$retval .= $this->buildRevisionLine( $rev, $title, ( $i == 0 ), ( $i == $count - 1 ) );
258	259	}
259	260	$retval .= Xml::closeElement( 'ul' );
—	—	@@ -277,7 +278,7 @@
278	279	$retval .= Xml::element( 'p', array(), wfMsg( 'changeauthor-explanation-single' ) );
279	280	$retval .= Xml::inputLabel( wfMsg( 'changeauthor-comment' ), 'comment', 'comment' );
280	281	$retval .= Xml::submitButton( wfMsg( 'changeauthor-changeauthors-single' ) );
281		~~- if( $errMsg != '' ) {~~
	282	+ if ( $errMsg != '' ) {
282	283	$retval .= Xml::openElement( 'p' ) . Xml::openElement( 'b' );
283	284	$retval .= Xml::element( 'font', array( 'color' => 'red' ), $errMsg );
284	285	$retval .= Xml::closeElement( 'b' ) . Xml::closeElement( 'p' );
—	—	@@ -299,27 +300,27 @@
300	301	global $wgRequest;
301	302	$vals = $wgRequest->getValues();
302	303	$retval = array();
303		~~- foreach( $vals as $name => $val ) {~~
304		~~- if( substr( $name, 0, 9 ) != 'user-new-' ) {~~
	304	+ foreach ( $vals as $name => $val ) {
	305	+ if ( substr( $name, 0, 9 ) != 'user-new-' ) {
305	306	continue;
306	307	}
307	308	$revid = substr( $name, 9 );
308		~~- if( !is_numeric( $revid ) ) {~~
	309	+ if ( !is_numeric( $revid ) ) {
309	310	continue;
310	311	}
311	312
312	313	$new = User::newFromName( $val, false );
313		~~- if( !$new ) { // Can this even happen?~~
	314	+ if ( !$new ) { // Can this even happen?
314	315	return wfMsg( 'changeauthor-invalid-username', $val );
315	316	}
316		~~- if( $new->getId() == 0 && $val != 'MediaWiki default' && !User::isIP( $new->getName() ) ) {~~
	317	+ if ( $new->getId() == 0 && $val != 'MediaWiki default' && !User::isIP( $new->getName() ) ) {
317	318	return wfMsg( 'changeauthor-nosuchuser', $val );
318	319	}
319	320	$old = User::newFromName( $wgRequest->getVal( "user-old-$revid" ), false );
320		~~- if( !$old->getName() ) {~~
	321	+ if ( !$old->getName() ) {
321	322	return wfMsg( 'changeauthor-invalidform' );
322	323	}
323		~~- if( $old->getName() != $new->getName() ) {~~
	324	+ if ( $old->getName() != $new->getName() ) {
324	325	$retval[$revid] = array( $old, $new );
325	326	}
326	327	}
—	—	@@ -336,7 +337,7 @@
337	338	$dbw->begin();
338	339	$editcounts = array(); // Array to keep track of EC mutations; key=userid, value=mutation
339	340	$log = new LogPage( 'changeauth' );
340		~~- foreach( $authors as $id => $users ) {~~
	341	+ foreach ( $authors as $id => $users ) {
341	342	$dbw->update(
342	343	'revision',
343	344	/* SET */array(
—	—	@@ -360,11 +361,11 @@
361	362	$editcounts[$users[1]->getId()]++;
362	363	$editcounts[$users[0]->getId()]--;
363	364	}
364		~~- foreach( $editcounts as $userid => $mutation ) {~~
365		~~- if( $mutation == 0 \|\| $userid == 0 ) {~~
	365	+ foreach ( $editcounts as $userid => $mutation ) {
	366	+ if ( $mutation == 0 \|\| $userid == 0 ) {
366	367	continue;
367	368	}
368		~~- if( $mutation > 0 ) {~~
	369	+ if ( $mutation > 0 ) {
369	370	$mutation = "+$mutation";
370	371	}
371	372	$dbw->update(
—	—	@@ -373,7 +374,7 @@
374	375	array( 'user_id' => $userid ),
375	376	__METHOD__
376	377	);
377		~~- if( $dbw->affectedRows() == 0 ) {~~
	378	+ if ( $dbw->affectedRows() == 0 ) {
378	379	// Let's have mercy on those who don't have a proper DB server
379	380	// (but not enough to spare their master)
380	381	$count = $dbw->selectField(
—	—	@@ -392,5 +393,4 @@
393	394	}
394	395	$dbw->commit();
395	396	}
396		-
397		-}
\ No newline at end of file
	397	+}
Index: trunk/extensions/ChangeAuthor/ChangeAuthor.i18n.php
—	—	@@ -15,8 +15,9 @@
16	16	* Written for the Bokt Wiki <http://www.bokt.nl/wiki/> by Roan Kattouw <roan.kattouw@home.nl>
17	17	* For information how to install and use this extension, see the README file.
18	18	*/
	19	+
19	20	# Alert the user that this is not a valid entry point to MediaWiki if they try to access the extension file directly.
20		~~-if( !defined( 'MEDIAWIKI' ) ) {~~
	21	+if ( !defined( 'MEDIAWIKI' ) ) {
21	22	echo <<<EOT
22	23	To install the ChangeAuthor extension, put the following line in LocalSettings.php:
23	24	require_once( "\$IP/extensions/ChangeAuthor/ChangeAuthor.setup.php" );
—	—	@@ -423,8 +424,8 @@
424	425	'changeauthor-nosuchuser' => 'L\'usuari "$1" no existeix.',
425	426	'changeauthor-revview' => 'Revisió número $1 de $2',
426	427	'changeauthor-nosuchtitle' => 'No hi ha cap pàgina anomenada "$1".',
427		~~- 'changeauthor-weirderror' => "Ha ocorregut un error poc comú.~~
428		~~-Si us plau, intenteu-ho de nou.~~
	428	+ 'changeauthor-weirderror' => "Ha ocorregut un error poc comú.
	429	+Si us plau, intenteu-ho de nou.
429	430	Si l'error persisteix, és probable que la base de dades estigui avariada.",
430	431	'changeauthor-invalidform' => 'Useu el formulari de la [[Special:ChangeAuthor\|pàgina especial]] adient.',
431	432	'changeauthor-success' => 'La vostra petició ha estat processada satisfactòriament.',
—	—	@@ -1397,7 +1398,7 @@
1398	1399	'changeauthor-pagenameform-go' => 'പോകൂ',
1399	1400	'changeauthor-comment' => 'അഭിപ്രായം:',
1400	1401	'changeauthor-changeauthors-multi' => 'ലേഖകരെ മാറ്റുക',
1401		- 'changeauthor-explanation-multi' => "ഈ താൾ ഉപയോഗിച്ച് താങ്കൾക്ക് ഒരു പതിപ്പിന്റെ ലേഖകനെ മാറ്റാവുന്നതാണ്‌.
	1402	+ 'changeauthor-explanation-multi' => "ഈ താൾ ഉപയോഗിച്ച് താങ്കൾക്ക് ഒരു പതിപ്പിന്റെ ലേഖകനെ മാറ്റാവുന്നതാണ്‌.
1402	1403	താഴെയുള്ള പട്ടികയിൽ ഒന്നോ അതിലധികമോ ഉപയോക്തൃനാമങ്ങൾ മാറ്റിയിട്ട്, അഭിപ്രായം രേഖപ്പെടുത്തിയതിനു ശേഷം (നിർബന്ധമില്ല), 'ലേഖകരെ മാറ്റുക' എന്ന ബട്ടൺ ഞെക്കുക.",
1403	1404	'changeauthor-changeauthors-single' => 'ലേഖകനെ മാറ്റുക',
1404	1405	'changeauthor-explanation-single' => "ഈ ഫോം ഉപയോഗിച്ച് ഒരു പതിപ്പിന്റെ ലേഖകനെ താങ്കൾക്ക് മാറ്റാവുന്നതാണ്‌. താഴെയുള്ള ഫോമിൽ ഉപയോക്തൃനാമം മാറ്റി, ലേഖകനെ മാറ്റാനുള്ള കാരണവും രേഖപ്പെടുത്തി (നിർബന്ധമില്ല), 'ലേഖകനെ മാറ്റുക' എന്ന ബട്ടൺ ഞെക്കുക.",
—	—	@@ -1520,7 +1521,7 @@
1521	1522	'changeauthor-pagenameform-go' => 'Gå',
1522	1523	'changeauthor-comment' => 'Kommentar:',
1523	1524	'changeauthor-changeauthors-multi' => 'Endra {{PLURAL:$1\|forfattar\|forfattarar}}',
1524		~~- 'changeauthor-explanation-multi' => 'Med dette skjemaet kan du endra kven som blir oppgjeve som forfattar til versjonar.~~
	1525	+ 'changeauthor-explanation-multi' => 'Med dette skjemaet kan du endra kven som blir oppgjeve som forfattar til versjonar.
1525	1526	Endra eitt eller fleire av brukarnamna i lista nedanfor, legg til ein (valfri) kommentar og trykk knappen «Endra forfattar(ar)».',
1526	1527	'changeauthor-changeauthors-single' => 'Endra forfattar',
1527	1528	'changeauthor-explanation-single' => 'Med dette skjemaet kan du endra på kven som blir oppgjeve som forfattaren til ein versjon. Endra brukarnamnet nedanfor, legg til ein (valfri) kommentar, og trykk på knappen «Endra forfattar».',
—	—	@@ -1740,8 +1741,8 @@
1741	1742	'changeauthor-nosuchuser' => 'Utilizador "$1" não existe.',
1742	1743	'changeauthor-revview' => 'Revisão #$1 de $2',
1743	1744	'changeauthor-nosuchtitle' => 'Não existe nenhuma página chamada "$1".',
1744		~~- 'changeauthor-weirderror' => 'Ocorreu um erro muito estranho.~~
1745		~~-Por favor, tente o seu pedido de novo.~~
	1745	+ 'changeauthor-weirderror' => 'Ocorreu um erro muito estranho.
	1746	+Por favor, tente o seu pedido de novo.
1746	1747	Se este erro persistir, provavelmente a base de dados não está em boas condições.',
1747	1748	'changeauthor-invalidform' => 'Por favor, utilize o formulário fornecido pela [[Special:ChangeAuthor\|página especial]] em vez de um formulário personalizado.',
1748	1749	'changeauthor-success' => 'O seu pedido foi processado com sucesso.',
—	—	@@ -2394,4 +2395,3 @@
2395	2396	'changeauthor-logentry' => '更改[[$1]]修訂版本$2的作者從 $3 到 $4',
2396	2397	'changeauthor-logpagename' => '作者更改日誌',
2397	2398	);
2398		-
Index: trunk/extensions/ChangeAuthor/README
—	—	@@ -19,7 +19,7 @@
20	20	This extension allows for changing the author of a revision, e.g. an edit made by Alice can be changed to look like it was made by Bob instead. Of course, only privileged users can do this, and all changes are logged.
21	21
22	22	2. WHERE TO GET CHANGEAUTHOR
23		~~-You can download a tarball at http://www.mediawiki.org/wiki/Special:ExtensionDistributor/ChangeAuthor .~~
	23	+You can download a tarball at http://www.mediawiki.org/wiki/Special:ExtensionDistributor/ChangeAuthor .
24	24
25	25	3. INSTALLATION
26	26	Download the tarball mentioned in section 2, and extract it in /path/to/your/wiki/extensions . Open LocalSettings.php and add the following line at the end:
—	—	@@ -45,7 +45,7 @@
46	46	$wgGroupPermissions['groupname']['changeauthor'] = true;
47	47
48	48	to LocalSettings.php (replace 'groupname' with the name of your custom group).
49		-NOTE: If a user is in multiple groups, they will be able to use ChangeAuthor even if that's allowed for only one of those groups. E.g.: if group A can't use ChangeAuthor but group B can, a user in both group A and B will be allowed to use ChangeAuthor.
	49	+NOTE: If a user is in multiple groups, they will be able to use ChangeAuthor even if that's allowed for only one of those groups. E.g.: if group A can't use ChangeAuthor but group B can, a user in both group A and B will be allowed to use ChangeAuthor.
50	50
51	51	4B. CREATING A NEW GROUP
52	52	You can also create a separate group for users who can use ChangeAuthor. To do this, add the following line to LocalSettings.php:
—	—	@@ -75,4 +75,4 @@
76	76	ChangeAuthor is currently maintained by Roan Kattouw. If you have any questions, complaints, feature requests, found a bug, or any other reason to contact the maintainer, please send your e-mails to roan.kattouw@home.nl and mention "ChangeAuthor" in the subject.
77	77
78	78	10. CREDITS
79		~~-ChangeAuthor was written for the Bokt Wiki <http://www.bokt.nl/wiki/> by Roan Kattouw <roan.kattouw@home.nl>~~
\ No newline at end of file
	79	+ChangeAuthor was written for the Bokt Wiki <http://www.bokt.nl/wiki/> by Roan Kattouw <roan.kattouw@home.nl>
Index: trunk/extensions/ChangeAuthor/ChangeAuthor.php
—	—	@@ -8,7 +8,7 @@
9	9	* @file
10	10	* @ingroup Extensions
11	11	* @author Roan Kattouw <roan.kattouw@home.nl>
12		~~- * @copyright Copyright © 2007 Roan Kattouw~~
	12	+ * @copyright Copyright © 2007 Roan Kattouw
13	13	* @license http://www.gnu.org/copyleft/gpl.html GNU General Public License
14	14	*
15	15	* An extension that allows changing the author of a revision
—	—	@@ -16,7 +16,7 @@
17	17	* For information how to install and use this extension, see the README file.
18	18	*/
19	19	# Alert the user that this is not a valid entry point to MediaWiki if they try to access the extension file directly.
20		~~-if( !defined( 'MEDIAWIKI' ) ) {~~
	20	+if ( !defined( 'MEDIAWIKI' ) ) {
21	21	echo <<<EOT
22	22	To install the ChangeAuthor extension, put the following line in LocalSettings.php:
23	23	require_once( "\$IP/extensions/ChangeAuthor/ChangeAuthor.php" );
—	—	@@ -35,7 +35,7 @@
36	36	);
37	37
38	38	// Set up the new special page
39		~~-$dir = dirname(__FILE__) . '/';~~
	39	+$dir = dirname( __FILE__ ) . '/';
40	40	$wgExtensionMessagesFiles['ChangeAuthor'] = $dir . 'ChangeAuthor.i18n.php';
41	41	$wgExtensionAliasesFiles['ChangeAuthor'] = $dir . 'ChangeAuthor.alias.php';
42	42	$wgAutoloadClasses['ChangeAuthor'] = $dir . 'ChangeAuthor.body.php';

Status & tagging log

20:07, 23 October 2010 Reedy (talk | contribs) changed the status of r65636 [removed: new added: deferred]