r65531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65530‎ | r65531 | r65532 >
Date:22:57, 25 April 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up 65339: fix 'pass by reference' warning as reported in bug 23322.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -242,7 +242,7 @@
243243 $desiredTitleObj = Title::newFromText( $this->mDesiredDestName, NS_FILE );
244244 $delNotice = ''; // empty by default
245245 if ( $desiredTitleObj instanceof Title && !$desiredTitleObj->exists() ) {
246 - LogEventsList::showLogExtract( &$delNotice, array( 'delete', 'move' ),
 246+ LogEventsList::showLogExtract( $delNotice, array( 'delete', 'move' ),
247247 $desiredTitleObj->getPrefixedText(),
248248 '', array( 'lim' => 10,
249249 'conds' => array( "log_action != 'revision'" ),

Status & tagging log