r65436 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65435‎ | r65436 | r65437 >
Date:19:51, 22 April 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6 - Fixed some bugs
Modified paths:
  • /trunk/extensions/Maps/Features/Maps_ParserFunctions.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispPoint.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispPoint.php
@@ -33,7 +33,7 @@
3434 * @see MapsBaseMap::doMapServiceLoad()
3535 *
3636 */
37 - protected function doMapServiceLoad() {
 37+ public function doMapServiceLoad() {
3838 global $egOpenLayersOnThisPage;
3939
4040 MapsOpenLayers::addOLDependencies( $this->output );
Index: trunk/extensions/Maps/Features/Maps_ParserFunctions.php
@@ -61,10 +61,10 @@
6262 foreach( $args as $arg ) {
6363 $split = explode( '=', $arg );
6464 $name = strtolower( trim( array_shift( $split ) ) );
65 - if ( count( $split ) > 1 && self::inParamAliases( $name, 'service', MapsMapper::getCommonParameters() ) ) {
 65+ if ( count( $split ) > 0 && self::inParamAliases( $name, 'service', MapsMapper::getCommonParameters() ) ) {
6666 if ( !$setService ) {
6767 $service = implode( '=', $split );
68 - $parameters = 'service=' . $service;
 68+ $parameters[] = 'service=' . $service;
6969 $setService = true;
7070 }
7171 } else {
@@ -73,7 +73,6 @@
7474 }
7575
7676 $service = MapsMapper::getValidService( $setService ? $service : '', $parserFunction );
77 -
7877 $mapClass = new $egMapsServices[$service]['features'][$parserFunction]();
7978
8079 $manager = new ValidatorManager();

Status & tagging log