r65319 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65318‎ | r65319 | r65320 >
Date:14:19, 20 April 2010
Author:demon
Status:ok
Tags:
Comment:
Merge r64454 from trunk
Modified paths:
  • /branches/REL1_16/phase3/includes/api/ApiBase.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/api/ApiBase.php
@@ -475,8 +475,10 @@
476476 $params = $this->getFinalParams();
477477 $results = array();
478478
479 - foreach ( $params as $paramName => $paramSettings ) {
480 - $results[$paramName] = $this->getParameterFromSettings( $paramName, $paramSettings, $parseLimit );
 479+ if ( $params ) { // getFinalParams() can return false
 480+ foreach ( $params as $paramName => $paramSettings ) {
 481+ $results[$paramName] = $this->getParameterFromSettings( $paramName, $paramSettings, $parseLimit );
 482+ }
481483 }
482484
483485 return $results;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64454Get rid of E_STRICT messagemah19:50, 31 March 2010

Status & tagging log