r65279 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65278‎ | r65279 | r65280 >
Date:14:46, 19 April 2010
Author:mkroetzsch
Status:deferred
Tags:
Comment:
provide default table assignments for telephone number datatype (automatic assignment picks wrong table; needs to be improved indepdentenly to support potential future extension datatypes properly)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStoreLight.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStoreLight.php
@@ -144,6 +144,7 @@
145145 '_ema' => 'smw_atts2', // Email type
146146 '_uri' => 'smw_atts2', // URL/URI type
147147 '_anu' => 'smw_atts2', // Annotation URI type
 148+ '_tel' => 'smw_atts2', // Telephone number
148149 '_wpg' => 'smw_rels2', // Page type
149150 '_wpp' => 'smw_rels2', // Property page type
150151 '_wpc' => 'smw_rels2', // Category page type
@@ -179,6 +180,7 @@
180181 '_ema' => array( 't', 0, 0 ), // Email type
181182 '_uri' => array( 't', 0, 0 ), // URL/URI type
182183 '_anu' => array( 't', 0, 0 ), // Annotation URI type
 184+ '_tel' => array( 't', 0, 0 ), // Telephone number
183185 '_wpg' => array( 'tnwt', 3, 3 ), // Page type
184186 '_wpp' => array( 'tnwt', 3, 3 ), // Property page type
185187 '_wpc' => array( 'tnwt', 3, 3 ), // Category page type
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -126,6 +126,7 @@
127127 '_ema' => 'smw_atts2', // Email type
128128 '_uri' => 'smw_atts2', // URL/URI type
129129 '_anu' => 'smw_atts2', // Annotation URI type
 130+ '_tel' => 'smw_atts2', // Telephone number
130131 '_wpg' => 'smw_rels2', // Page type
131132 '_wpp' => 'smw_rels2', // Property page type
132133 '_wpc' => 'smw_rels2', // Category page type
@@ -160,6 +161,7 @@
161162 '_ema' => array( 't', 0, 0 ), // Email type
162163 '_uri' => array( 't', 0, 0 ), // URL/URI type
163164 '_anu' => array( 't', 0, 0 ), // Annotation URI type
 165+ '_tel' => array( 't', 0, 0 ), // Telephone number
164166 '_wpg' => array( 'tnwt', 3, 3 ), // Page type
165167 '_wpp' => array( 'tnwt', 3, 3 ), // Property page type
166168 '_wpc' => array( 'tnwt', 3, 3 ), // Category page type
@@ -2079,7 +2081,7 @@
20802082 SMWSQLStore2::$prop_tables['smw_redi2']->idsubject = false;
20812083
20822084 wfRunHooks( 'SMWPropertyTables', array( &SMWSQLStore2::$prop_tables ) );
2083 -
 2085+
20842086 return SMWSQLStore2::$prop_tables;
20852087 }
20862088

Status & tagging log