r65216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65215‎ | r65216 | r65217 >
Date:11:58, 18 April 2010
Author:ialex
Status:ok
Tags:
Comment:
Per report on translatewiki: "namespaces to search" user option always displays all fields unchecked
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
@@ -1270,7 +1270,7 @@
12711271 } else {
12721272 $thisAttribs = array( 'id' => $this->mID . "-$info", 'value' => $info );
12731273
1274 - $checkbox = Xml::check( $this->mName . '[]', $info === $value,
 1274+ $checkbox = Xml::check( $this->mName . '[]', in_array( $info, $value, true ),
12751275 $attribs + $thisAttribs );
12761276 $checkbox .= ' ' . Html::rawElement( 'label', array( 'for' => $this->mID . "-$info" ), $label );
12771277

Status & tagging log