r65209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65208‎ | r65209 | r65210 >
Date:11:04, 18 April 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup for r65181
Modified paths:
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -168,8 +168,8 @@
169169 $selected = 0;
170170
171171 foreach ( $versions as $branchPath => $branchName ) {
172 - $wgOut->addHTML( Xml::element( 'option',
173 - array( 'value' => $branchPath, 'selected' => ( ( $selected == 1 ) ? 'selected' : '' ) ), $branchName ) . "\n" );
 172+ $wgOut->addHTML( Xml::option( $branchName, $branchPath, ($selected == 1) ) );
 173+
174174 $selected++;
175175 }
176176 $wgOut->addHTML(

Follow-up revisions

RevisionCommit summaryAuthorDate
r779011.16wmf4: MFT r65181, r65209catrope20:20, 6 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65181Apply my patch for Bug 19155 - Make the selection box for ExtensionDistributo...reedy20:47, 17 April 2010

Status & tagging log