r65133 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65132‎ | r65133 | r65134 >
Date:16:57, 16 April 2010
Author:ialex
Status:ok
Tags:
Comment:
Don't use wfMsgExt with parseinline and escape it after; this breaks languages using spaces before colons (since the " " automatically added by Parser::parse() is escaped)
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
@@ -45,7 +45,7 @@
4646 Xml::openElement( 'fieldset' ) .
4747 Xml::element( 'legend', array(), wfMsg( 'userrights-lookup-user' ) ) .
4848 Xml::inputLabel( wfMsg( 'userrights-user-editname' ), 'user', 'username', 30, $this->mTarget ) . ' <br />' .
49 - Xml::label( wfMsgExt('centralauth-globalgrouppermissions-knownwiki', array('parseinline')), 'wpKnownWiki' ) .
 49+ Xml::label( wfMsg( 'centralauth-globalgrouppermissions-knownwiki' ), 'wpKnownWiki' ) . ' ' .
5050 $selector->getHTML() . '<br />' .
5151 Xml::submitButton( wfMsg( 'editusergroup' ) ) .
5252 Xml::closeElement( 'fieldset' ) .

Status & tagging log