r64925 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64924‎ | r64925 | r64926 >
Date:07:57, 11 April 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixes for r64903:
* changed execute() signature to be compatible with SpecialPage::execute()
* changed $to to $target since the former is not defined at this point, and corrected message name
* removed trailing spaces
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -61,7 +61,7 @@
6262 );
6363 }
6464
65 - public function execute( $par=null ) {
 65+ public function execute( $par ) {
6666 global $wgRequest, $wgOut, $wgUser;
6767 $this->mTarget = is_null( $par )
6868 ? $wgRequest->getVal( 'wpTarget', '' )
@@ -192,7 +192,7 @@
193193 if ( $hookErr ) {
194194 return $hookErr;
195195 }
196 -
 196+
197197 return null;
198198 }
199199
@@ -208,7 +208,7 @@
209209
210210 $target = self::getTarget( $data['Target'] );
211211 if( !$target instanceof User ){
212 - return wfMsgExt( $to, 'parse' );
 212+ return wfMsgExt( $target . 'text', 'parse' );
213213 }
214214 $to = new MailAddress( $target );
215215 $from = new MailAddress( $wgUser );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64903Overhaul Special:EmailUser, use HTMLForm, a SpecialPage-derived class, and ge...happy-melon21:14, 10 April 2010

Status & tagging log