r64861 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64860‎ | r64861 | r64862 >
Date:10:09, 10 April 2010
Author:catrope
Status:resolved
Tags:
Comment:
1.16wmf4: MFT r64860
Modified paths:
  • /branches/wmf/1.16wmf4/includes/specials (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialEmailuser.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Property changes on: branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php
___________________________________________________________________
Name: svn:mergeinfo
11 - /branches/REL1_15/phase3/includes/specials/SpecialUserlogin.php:51646
/branches/sqlite/includes/specials/SpecialUserlogin.php:58211-58321
/branches/wmf-deployment/includes/specials/SpecialUserlogin.php:53381,56967,60970
/trunk/phase3/includes/specials/SpecialUserlogin.php:63045,63047,63490,63549,63764,63897-63901,64837,64846
22 + /branches/REL1_15/phase3/includes/specials/SpecialUserlogin.php:51646
/branches/sqlite/includes/specials/SpecialUserlogin.php:58211-58321
/branches/wmf-deployment/includes/specials/SpecialUserlogin.php:53381,56967,60970
/trunk/phase3/includes/specials/SpecialUserlogin.php:63045,63047,63490,63549,63764,63897-63901,64837,64846,64860
Index: branches/wmf/1.16wmf4/includes/specials/SpecialEmailuser.php
@@ -274,7 +274,7 @@
275275 }
276276
277277 $nu = User::newFromName( $nt->getText() );
278 - if( is_null( $nu ) || !$nu->getId() ) {
 278+ if( !$nu instanceof Title || !$nu->getId() ) {
279279 wfDebug( "Target is invalid user.\n" );
280280 return "notarget";
281281 } else if ( !$nu->isEmailConfirmed() ) {
Property changes on: branches/wmf/1.16wmf4/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
282282 - /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967,60970
/trunk/phase3/includes/specials:63045,63047,63549,63764,63897-63901,64846
283283 + /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967,60970
/trunk/phase3/includes/specials:63045,63047,63549,63764,63897-63901,64846,64860

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64860Fix yet another instance of comparing the result of User::newFromName to nullcatrope10:08, 10 April 2010

Status & tagging log