r64830 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64829‎ | r64830 | r64831 >
Date:20:47, 9 April 2010
Author:platonides
Status:deferred
Tags:
Comment:
Follow up r64828. It was a typo, there's no variable called $wgDisableContentConversion
Modified paths:
  • /branches/REL1_16/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -303,7 +303,7 @@
304304 * to internalParse() which does all the real work.
305305 */
306306
307 - global $wgUseTidy, $wgAlwaysUseTidy, $wgContLang, $wgDisableLangConversion, $wgUser, $wgRequest, $wgDisableTitleConversion;
 307+ global $wgUseTidy, $wgAlwaysUseTidy, $wgContLang, $wgDisableLangConversion, $wgDisableTitleConversion, $wgUser, $wgRequest;
308308 $fname = __METHOD__.'-' . wfGetCaller();
309309 wfProfileIn( __METHOD__ );
310310 wfProfileIn( $fname );
@@ -363,7 +363,7 @@
364364
365365 /**
366366 * A page get its title converted except:
367 - * a) Content convert is globally disabled
 367+ * a) Language conversion is globally disabled
368368 * b) Title convert is globally disabled
369369 * c) The page is a redirect page
370370 * d) User request with a "linkconvert" set to "no"
Index: branches/wmf/1.16wmf4/includes/parser/Parser.php
@@ -365,7 +365,7 @@
366366
367367 /**
368368 * A page get its title converted except:
369 - * a) Content convert is globally disabled
 369+ * a) Language conversion is globally disabled
370370 * b) Title convert is globally disabled
371371 * c) The page is a redirect page
372372 * d) User request with a "linkconvert" set to "no"
@@ -377,7 +377,7 @@
378378 * rule but content conversion was not done, then the parser
379379 * won't pick it up. This is probably expected behavior.
380380 */
381 - if ( !( $wgDisableContentConversion
 381+ if ( !( $wgDisableLangConversion
382382 || $wgDisableTitleConversion
383383 || $wgRequest->getText( 'redirect', 'yes' ) == 'no'
384384 || $wgRequest->getText( 'linkconvert', 'yes' ) == 'no'
Index: branches/REL1_16/phase3/includes/parser/Parser.php
@@ -365,7 +365,7 @@
366366
367367 /**
368368 * A page get its title converted except:
369 - * a) Content convert is globally disabled
 369+ * a) Language conversion is globally disabled
370370 * b) Title convert is globally disabled
371371 * c) The page is a redirect page
372372 * d) User request with a "linkconvert" set to "no"
@@ -377,7 +377,7 @@
378378 * rule but content conversion was not done, then the parser
379379 * won't pick it up. This is probably expected behavior.
380380 */
381 - if ( !( $wgDisableContentConversion
 381+ if ( !( $wgDisableLangConversion
382382 || $wgDisableTitleConversion
383383 || $wgRequest->getText( 'redirect', 'yes' ) == 'no'
384384 || $wgRequest->getText( 'linkconvert', 'yes' ) == 'no'

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64828Follow-up r64819: PHP Notice: Undefined variable: wgDisableContentConversion ...raymond20:34, 9 April 2010

Status & tagging log