r64804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64803‎ | r64804 | r64805 >
Date:15:28, 9 April 2010
Author:thomasv
Status:ok
Tags:
Comment:
workaround: skins/common/edit.js assumes that the first textarea in the page is visible
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -33,7 +33,7 @@
3434 $wgSpecialPageGroups['IndexPages'] = 'pages';
3535
3636 # Bump the version number every time you change proofread.js
37 -$wgProofreadPageVersion = 25;
 37+$wgProofreadPageVersion = 26;
3838
3939 # Max width of zoomable image
4040 $wgProofreadPageMaxWidth = 2048;
Index: trunk/extensions/ProofreadPage/proofread.js
@@ -157,14 +157,14 @@
158158 pageFooter = pageFooter.split("&").join("&")
159159
160160 container.innerHTML = ''
161 - + '<div id="prp_header" style="display:none;">'
 161+ + '<div id="prp_header" style="">'
162162 + '<span style="color:gray;font-size:80%;line-height:100%;">'
163163 + escapeQuotesHTML(proofreadPageMessageHeader) + '</span>'
164164 + '<textarea name="wpHeaderTextbox" rows="2" cols="80" tabindex=1>' + pageHeader + '</textarea><br/>'
165165 + '<span style="color:gray;font-size:80%;line-height:100%;">'
166166 + escapeQuotesHTML(proofreadPageMessagePageBody) + '</span></div>'
167167 + '<textarea name="wpTextbox1" id="wpTextbox1" tabindex=1 style="height:' + ( self.DisplayHeight - 6 ) + 'px;">' + pageBody + '</textarea>'
168 - + '<div id="prp_footer" style="display:none;">'
 168+ + '<div id="prp_footer" style="">'
169169 + '<span style="color:gray;font-size:80%;line-height:100%;">'
170170 + escapeQuotesHTML(proofreadPageMessageFooter) + '</span><br/>'
171171 + '<textarea name="wpFooterTextbox" rows="2" cols="80" tabindex=1>'+pageFooter+'</textarea></div>';
@@ -718,8 +718,8 @@
719719 pr_make_edit_area(self.text_container,new_text.value);
720720 var copywarn = document.getElementById("editpage-copywarn");
721721 f.insertBefore(table,copywarn);
722 - if (self.proofreadpage_show_headers){
723 - pr_toggle_visibility();
 722+ if ( ! self.proofreadpage_show_headers){
 723+ hookEvent( 'load', pr_toggle_visibility );
724724 }
725725 }
726726 else {

Status & tagging log