r64783 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64782‎ | r64783 | r64784 >
Date:10:39, 9 April 2010
Author:catrope
Status:ok
Tags:
Comment:
1.16wmf4: MFT r63490
Modified paths:
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php
@@ -453,7 +453,7 @@
454454 # TODO: Allow some magic here for invalid external names, e.g., let the
455455 # user choose a different wiki name.
456456 $u = User::newFromName( $this->mName );
457 - if( is_null( $u ) || !User::isUsableName( $u->getName() ) ) {
 457+ if( !( $u instanceof User ) || !User::isUsableName( $u->getName() ) ) {
458458 return self::ILLEGAL;
459459 }
460460
Property changes on: branches/wmf/1.16wmf4/includes/specials/SpecialUserlogin.php
___________________________________________________________________
Name: svn:mergeinfo
461461 + /branches/REL1_15/phase3/includes/specials/SpecialUserlogin.php:51646
/branches/sqlite/includes/specials/SpecialUserlogin.php:58211-58321
/branches/wmf-deployment/includes/specials/SpecialUserlogin.php:53381,56967,60970
/trunk/phase3/includes/specials/SpecialUserlogin.php:63045,63047,63490,63549,63764,63897-63901

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63490Avoid fatal on login if username is invalid title...simetrical19:27, 9 March 2010

Status & tagging log