r64772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64771‎ | r64772 | r64773 >
Date:02:32, 9 April 2010
Author:tstarling
Status:ok
Tags:
Comment:
MFT r64771: Make Special:CentralAuth work with the pre-r61737 schema.
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CentralAuth (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuthUser.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuthUser.php
@@ -403,9 +403,12 @@
404404 public function getHiddenLevel() {
405405 $this->loadState();
406406
407 - // b/c-failsafe. Should never happen
408 - if( $this->mHidden === '0' )
 407+ // backwards compatibility for mid-migration
 408+ if( strval( $this->mHidden ) === '0' ) {
409409 $this->mHidden = '';
 410+ } elseif ( strval( $this->mHidden ) === '1' ) {
 411+ $this->mHidden = self::HIDDEN_LISTS;
 412+ }
410413
411414 return $this->mHidden;
412415 }
Property changes on: branches/wmf/1.16wmf4/extensions/CentralAuth
___________________________________________________________________
Name: svn:mergeinfo
413416 - /branches/wmf-deployment/extensions/CentralAuth:60970
/trunk/extensions/CentralAuth:62827
414417 + /branches/wmf-deployment/extensions/CentralAuth:60970
/trunk/extensions/CentralAuth:62827,64771

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61737Rewrite CentralAuth admin form and lock/hide mechanism. Changes:...vasilievvv02:41, 31 January 2010
r64771Make Special:CentralAuth work with the pre-r61737 schema.tstarling02:30, 9 April 2010

Status & tagging log