r64705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64704‎ | r64705 | r64706 >
Date:15:03, 7 April 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Small performance tweak
Modified paths:
  • /trunk/extensions/Maps/INSTALL (modified) (history)
  • /trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_BasePointMap.php (modified) (history)
  • /trunk/extensions/Maps/ParserFunctions/Maps_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/ParserFunctions/DisplayPoint/Maps_BasePointMap.php
@@ -25,14 +25,13 @@
2626 abstract class MapsBasePointMap extends MapsMapFeature implements iDisplayFunction {
2727
2828 private $markerData = array();
29 - protected $markerStringFormat = '';
3029 protected $markerString;
3130
3231 /**
3332 * Handles the request from the parser hook by doing the work that's common for all
3433 * mapping services, calling the specific methods and finally returning the resulting output.
3534 *
36 - * @param unknown_type $parser
 35+ * @param Parser $parser
3736 * @param array $params
3837 *
3938 * @return html
Index: trunk/extensions/Maps/ParserFunctions/Maps_ParserFunctions.php
@@ -300,7 +300,7 @@
301301 public static function paramIsPresent( $paramName, array $stack, array $paramInfo = array(), $checkForAliases = true ) {
302302 $isPresent = array_key_exists( $paramName, $stack );
303303
304 - if ( $checkForAliases && array_key_exists( 'aliases', $paramInfo[$paramName] ) ) {
 304+ if ( !$isPresent && $checkForAliases && array_key_exists( 'aliases', $paramInfo[$paramName] ) ) {
305305 foreach ( $paramInfo[$paramName]['aliases'] as $alias ) {
306306 if ( array_key_exists( $alias, $stack ) ) {
307307 $isPresent = true;
Index: trunk/extensions/Maps/INSTALL
@@ -1,4 +1,4 @@
2 -[[Maps 0.5.5]]
 2+[[Maps 0.6]]
33
44 In order to use this version of Maps, you need to have Validator 0.2.2 installed. If you get a distribution
55 from this page, you don't need to bother this, since Validator comes bundled with every release, and will

Status & tagging log