r64696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64695‎ | r64696 | r64697 >
Date:08:56, 7 April 2010
Author:reedy
Status:ok
Tags:
Comment:
Fixup to r64197 per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/64197#c6451

Pass $fromTitle rather than $titleObj (which is undefined)
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMove.php
@@ -123,7 +123,7 @@
124124 }
125125
126126 // Watch pages
127 - $watch = $this->getWatchlistValue( $params['watchlist'], $titleObj ) || $wgUser->getOption( 'watchmoves' );
 127+ $watch = $this->getWatchlistValue( $params['watchlist'], $fromTitle ) || $wgUser->getOption( 'watchmoves' );
128128
129129 // Deprecated parameters
130130 if ( $params['watch'] ) {
Index: trunk/phase3/includes/api/ApiBase.php
@@ -534,6 +534,7 @@
535535
536536 return $mValidNamespaces;
537537 }
 538+
538539 /**
539540 * Handle watchlist settings
540541 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64197Fix bug 22944 in a much better fashion (using watchlist parameter)...reedy22:15, 25 March 2010

Status & tagging log