r64693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64692‎ | r64693 | r64694 >
Date:08:04, 7 April 2010
Author:aaron
Status:ok
Tags:
Comment:
Removed $wgFlaggedRevsPatrolLevel (unused) for same reason as r63609
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -138,10 +138,6 @@
139139 'accuracy' => 1, 'depth' => 1, 'style' => 1
140140 );
141141
142 -# At what level of review do patrol marks go away?
143 -# (FR_SIGHTED,FR_QUALITY,FR_PRISTINE)
144 -$wgFlaggedRevsPatrolLevel = FR_SIGHTED;
145 -
146142 # Restriction levels for 'autoreview'/'review' rights.
147143 # When a level is selected for a page, an edit made by a user
148144 # requires approval unless that user has the specified permission.
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -448,15 +448,6 @@
449449 }
450450
451451 /**
452 - * Get minimum tier for a revision to count as patrolled
453 - * @return int
454 - */
455 - public static function getPatrolLevel() {
456 - global $wgFlaggedRevsPatrolLevel;
457 - return (int)$wgFlaggedRevsPatrolLevel;
458 - }
459 -
460 - /**
461452 * Get minimum level tags for a tier
462453 * @return array
463454 */
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1091,7 +1091,7 @@
10921092 if ( $fa->isReviewable( FR_MASTER ) ) {
10931093 $revId = $rc->mAttribs['rc_this_oldid'];
10941094 $quality = FlaggedRevs::getRevQuality( $rc->mAttribs['rc_cur_id'], $revId, FR_MASTER );
1095 - if ( $quality !== false && $quality >= FlaggedRevs::getPatrolLevel() ) {
 1095+ if ( $quality !== false && $quality >= FR_SIGHTED ) {
10961096 RevisionReview::updateRecentChanges( $rc->getTitle(), $revId );
10971097 $rc->mAttribs['rc_patrolled'] = 1; // make sure irc/email notifs know status
10981098 }
@@ -1786,7 +1786,7 @@
17871787 if ( $wgUser->isAllowed( 'review' ) ) {
17881788 $tables[] = 'flaggedpage_pending';
17891789 $join_conds['flaggedpage_pending'] = array( 'LEFT JOIN',
1790 - 'fpp_page_id = rc_cur_id AND fpp_quality = ' . FlaggedRevs::getPatrolLevel() );
 1790+ 'fpp_page_id = rc_cur_id AND fpp_quality = ' . FR_SIGHTED );
17911791 }
17921792 return true;
17931793 }
@@ -1797,7 +1797,7 @@
17981798 $fields[] = 'fpp_rev_id';
17991799 $tables[] = 'flaggedpage_pending';
18001800 $join_conds['flaggedpage_pending'] = array( 'LEFT JOIN',
1801 - 'fpp_page_id = rc_cur_id AND fpp_quality = ' . FlaggedRevs::getPatrolLevel() );
 1801+ 'fpp_page_id = rc_cur_id AND fpp_quality = ' . FR_SIGHTED );
18021802 }
18031803 return true;
18041804 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63609Pull back recent $wgFlagAvailability var, likely not be needed (and complicat...aaron18:14, 11 March 2010

Status & tagging log