r64595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64594‎ | r64595 | r64596 >
Date:12:01, 4 April 2010
Author:ialex
Status:ok
Tags:
Comment:
Avoid PHP notice about undefined variable $diffText if $wgFeedDiffCutoff is 0
Modified paths:
  • /trunk/phase3/includes/FeedUtils.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FeedUtils.php
@@ -124,7 +124,7 @@
125125 $wgLang->time( $timestamp ) ) );
126126 }
127127
128 - if ( ( strlen( $diffText ) > $wgFeedDiffCutoff ) || ( $wgFeedDiffCutoff <= 0 ) ) {
 128+ if ( $wgFeedDiffCutoff <= 0 || ( strlen( $diffText ) > $wgFeedDiffCutoff ) ) {
129129 // Omit large diffs
130130 $diffLink = $title->escapeFullUrl(
131131 'diff=' . $newid .

Status & tagging log