r64562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64561‎ | r64562 | r64563 >
Date:14:48, 3 April 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 18499) Added "enhanced" URL parameter to switch between old and enhanced changes list
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -44,11 +44,13 @@
4545 * @return ChangesList derivative
4646 */
4747 public static function newFromUser( &$user ) {
 48+ global $wgRequest;
 49+
4850 $sk = $user->getSkin();
4951 $list = null;
5052 if( wfRunHooks( 'FetchChangesList', array( &$user, &$sk, &$list ) ) ) {
51 - return $user->getOption( 'usenewrc' ) ?
52 - new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
 53+ $new = $wgRequest->getBool( 'enhanced', $user->getOption( 'usenewrc' ) );
 54+ return $new ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
5355 } else {
5456 return $list;
5557 }
Index: trunk/phase3/RELEASE-NOTES
@@ -37,6 +37,8 @@
3838 * Support git:// and mms:// protocols by default for external links
3939 * (bug 15810) Blocked admins can no longer unblock themselves without the
4040 'unblockself' permission (which they have by default)
 41+* (bug 18499) Added "enhanced" URL parameter to switch between old and enhanced
 42+ changes list
4143
4244 === Bug fixes in 1.17 ===
4345 * (bug 17560) Half-broken deletion moved image files to deletion archive without

Status & tagging log