r64557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64556‎ | r64557 | r64558 >
Date:08:56, 3 April 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 22852) "Served in" comment is now the time used to cache a single page when using rebuildFileCache.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/rebuildFileCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildFileCache.php
@@ -32,7 +32,7 @@
3333 }
3434
3535 public function execute() {
36 - global $wgUseFileCache, $wgDisableCounters, $wgContentNamespaces;
 36+ global $wgUseFileCache, $wgDisableCounters, $wgContentNamespaces, $wgRequestTime;
3737 global $wgTitle, $wgArticle, $wgOut, $wgUser;
3838 if( !$wgUseFileCache ) {
3939 $this->error( "Nothing to do -- \$wgUseFileCache is disabled.", true );
@@ -72,6 +72,7 @@
7373 );
7474 foreach( $res as $row ) {
7575 $rebuilt = false;
 76+ $wgRequestTime = wfTime(); # bug 22852
7677 $wgTitle = Title::makeTitleSafe( $row->page_namespace, $row->page_title );
7778 if( null == $wgTitle ) {
7879 $this->output( "Page {$row->page_id} has bad title\n" );
@@ -91,7 +92,7 @@
9293 continue; // done already!
9394 }
9495 }
95 - ob_start( array(&$cache, 'saveToFileCache' ) ); // save on ob_end_clean()
 96+ ob_start( array( &$cache, 'saveToFileCache' ) ); // save on ob_end_clean()
9697 $wgUseFileCache = false; // hack, we don't want $wgArticle fiddling with filecache
9798 $wgArticle->view();
9899 @$wgOut->output(); // header notices
Index: trunk/phase3/RELEASE-NOTES
@@ -75,6 +75,8 @@
7676 * (bug 22867) "View source" tab is now only displayed if there's source text
7777 * (bug 19393) Feeds now format dates in user language rather than content
7878 language
 79+* (bug 22852) "Served in" comment is now the time used to cache a single page
 80+ when using rebuildFileCache.php
7981
8082 === API changes in 1.17 ===
8183 * (bug 22738) Allow filtering by action type on query=logevent

Status & tagging log