r64539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64538‎ | r64539 | r64540 >
Date:21:48, 2 April 2010
Author:tparscal
Status:ok
Tags:
Comment:
Updated the logic to handle anon users properly (just show them what's new, not give them feedback or opt-out channels)
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -64,23 +64,26 @@
6565 'prefswitch-success-on' => 'New features are now turned on.',
6666 'prefswitch-success-off' => 'New features are now turned off.',
6767 'prefswitch-success-feedback' => 'Your feedback has been sent.',
68 - 'prefswitch-return' => '<hr>
 68+ 'prefswitch-return' => '<hr style="clear:both">
6969 Return to <span class="plainlinks">[$1 $2]</span>.',
7070 'prefswitch-main' => "We've been working hard to make things easier for our users. We're excited to share some improvements, including a new look and feel and simplified editing features. Improving the usability of the site is an ongoing effort here at Wikimedia and we'll be sharing more updates in the future.
7171
72 -Here's what we've recently launched:
 72+[[File:UsabilityNavigation.png|right|link=|Screenshot of the new navigation]]
 73+[[File:UsabilityToolbar.png|right|link=|Screenshot of the enhanced edit toolbar]]
 74+[[File:UsabilityDialogs.png|right|link=|Screenshot of the new content generation dialogs]]
 75+===Here's what we've recently launched:===
7376 * Navigation: We've improved the navigation for reading and editing articles. Now, the tabs at the top of each page more clearly define whether you're viewing the article page or discussion page, and whether you're reading or editing an article.
7477 * Editing toolbar improvements: We've reorganized the editing toolbar to make easier to use. Now, formatting articles is simpler and more intuitive.
7578 * Link wizard: An easy-to-use tool allows you to add links to other Wikipedia articles as well as links to external sites.
7679 * Search improvements: We've improved search suggestions to get you to the article you're looking for more quickly.
7780 * Other new features: We've also introduced a table wizard to make creating tables easier and find and a replace feature to simplify article editing.",
7881 'prefswitch-main-on' => "
79 -;Feedback?
 82+===Feedback?===
8083 We would love to hear from you. Please visit our <span class=\"plainlinks\">[$1 feedback page]</span>.
81 -;Take me back!
 84+===Take me back!===
8285 If you would like to turn off the new features, please <span class=\"plainlinks\">[$2 click here]</span>.",
8386 'prefswitch-main-off' => "
84 -;Try them out!
 87+===Try them out!===
8588 If you would like to turn on the new features, please <span class=\"plainlinks\">[$1 click here]</span>.",
8689 'prefswitch-survey-intro-feedback' => "We'd love to hear from you. Please fill out the optional survey below.",
8790 'prefswitch-survey-intro-off' => 'Thanks for trying out our new features. To help us improve them, please fill out the optional survey below ',
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php
@@ -223,7 +223,7 @@
224224 $wgOut->addWikiMsg(
225225 'prefswitch-main', array( 'parse' )
226226 );
227 - if ( self::isSwitchedOn( $wgUser ) ) {
 227+ if ( self::isSwitchedOn( $wgUser ) && !$wgUser->isAnon() ) {
228228 $wgOut->addWikiMsgArray(
229229 'prefswitch-main-on',
230230 array(
@@ -232,7 +232,7 @@
233233 ),
234234 array( 'parse' )
235235 );
236 - } else {
 236+ } else if ( !$wgUser->isAnon() ) {
237237 $wgOut->addWikiMsgArray(
238238 'prefswitch-main-off',
239239 array(

Status & tagging log