r64536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64535‎ | r64536 | r64537 >
Date:21:24, 2 April 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added some messages and fixed a bad mid-air collision.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.classes.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.classes.php
@@ -293,7 +293,7 @@
294294 public static function save( $question, $request ) {
295295 $answer = $request->getVal( "prefswitch-survey-{$question}", null );
296296 return array(
297 - 'pss_answer' => $answer
 297+ 'pss_answer' => $answer,
298298 'pss_answer_data' => $answer == 'true' || $answer == 'false' ?
299299 $request->getVal( "prefswitch-survey-{$question}-if{$answer}", null ) : null,
300300 );
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -16,9 +16,9 @@
1717 'prefswitch-desc' => 'Allow users to swtich sets of preferences',
1818 'prefswitch-survey-true' => 'Yes',
1919 'prefswitch-survey-false' => 'No',
20 - 'prefswitch-survey-submit-off' => 'Turn New Features Off',
 20+ 'prefswitch-survey-submit-off' => 'Turn new features off',
2121 'prefswitch-survey-cancel-off' => 'If you would like to continue using the new features, you can return to $1.',
22 - 'prefswitch-survey-submit-feedback' => 'Send Feedback',
 22+ 'prefswitch-survey-submit-feedback' => 'Send feedback',
2323 'prefswitch-survey-cancel-feedback' => 'If you don\'t want to provide feedback, you can return to $1.',
2424 'prefswitch-survey-question-likedislike' => 'What did you like about the new features? What did you dislike about the features?',
2525 'prefswitch-survey-question-whyoff' => 'Why are you turning off the new features? (Please select all that apply.)',
@@ -61,6 +61,9 @@
6262 'prefswitch-title-off' => 'Turn New Features Off',
6363 'prefswitch-title-switched-off' => 'Thanks',
6464 'prefswitch-title-feedback' => 'Give Feedback',
 65+ 'prefswitch-success-on' => 'New features are now turned on.',
 66+ 'prefswitch-success-off' => 'New features are now turned off.',
 67+ 'prefswitch-success-feedback' => 'Your feedback has been sent.',
6568 'prefswitch-return' => '<hr>
6669 Return to <span class="plainlinks">[$1 $2]</span>.',
6770 'prefswitch-main' => 'We\'ve been working hard to make things easier for our users. We\'re excited to share some improvements, including a new look and feel and simplified editing features. Improving the usability of the site is an ongoing effort here at Wikimedia and we\'ll be sharing more updates in the future.
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php
@@ -201,7 +201,7 @@
202202 'method' => 'post',
203203 'action' => $this->getTitle()->getLinkURL( $query ),
204204 'class' => 'prefswitch-survey',
205 - 'id' => "prefswitch-survey-{$name}",
 205+ 'id' => "prefswitch-survey-{$mode}"
206206 )
207207 );
208208 $html .= Xml::hidden( 'mode', $mode );

Status & tagging log