r64527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64526‎ | r64527 | r64528 >
Date:20:04, 2 April 2010
Author:tparscal
Status:ok
Tags:
Comment:
Made some progress with parser stuff.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -65,11 +65,12 @@
6666 * Search improvements: We\'ve improved search suggestions to get you to the article you\'re looking for more quickly.
6767 * Other new features: We\'ve also introduced a table wizard to make creating tables easier and find and a replace feature to simplify article editing.
6868
69 -Feedback? We\'ve love to hear from you. Please visit our <a href="$3">feedback page</a>.
70 -Take me back. If you would like to turn off the new features, please <a href="$2">click here</a>.
 69+;Feedback?
 70+We\'ve love to hear from you. Please visit our [$4 feedback page].
 71+;Take me back!
 72+If you would like to turn off the new features, please [$3 click here].
7173
72 -
73 - Provide feedback</a>, turn stuff off</a> or return to $1.',
 74+or return to [$1 $2].',
7475 'prefswitch-survey-intro-feedback' => 'We\'d love to hear from you. Please fill out the optional survey below.',
7576 'prefswitch-survey-intro-off' => 'Thanks for trying out our new features. To help us improve them, please fill out the optional survey below ',
7677 );
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php
@@ -14,7 +14,7 @@
1515 private $originTitle = null;
1616 private $originQuery = '';
1717 private $originLink = '';
18 - private $originURL = '';
 18+ private $originUrl = '';
1919
2020 /* Static Functions */
2121
@@ -92,7 +92,7 @@
9393 $this->origin = $this->originTitle->getPrefixedDBKey();
9494 $this->originQuery = $wgRequest->getVal( 'fromquery' );
9595 $this->originLink = $wgUser->getSkin()->link( $this->originTitle, null, array(), $this->originQuery );
96 - $this->originURL = $this->originTitle->getLinkUrl( $this->originQuery );
 96+ $this->originUrl = $this->originTitle->getLinkUrl( $this->originQuery );
9797 }
9898 // Begin output
9999 $this->setHeaders();
@@ -174,7 +174,7 @@
175175 $this->render( 'main' );
176176 }
177177 }
178 -
 178+
179179 /* Private Functions */
180180
181181 private function render( $mode = null ) {
@@ -215,11 +215,12 @@
216216 $wgOut->addWikiMsgArray(
217217 'prefswitch-main',
218218 array(
219 - $this->originLink,
 219+ $this->originUrl,
 220+ $this->originTitle,
220221 $this->getTitle()->getLinkURL( array_merge( $query, array( 'mode' => 'off' ) ) ),
221222 $this->getTitle()->getLinkURL( array_merge( $query, array( 'mode' => 'feedback' ) ) )
222223 ),
223 - array( 'parse', 'replaceafter' )
 224+ array( 'parse' )
224225 );
225226 }
226227 }

Status & tagging log