r64524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64523‎ | r64524 | r64525 >
Date:18:09, 2 April 2010
Author:tparscal
Status:ok
Tags:
Comment:
More CSS fixes. Also some filling in of the missing i18n stuff.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -16,6 +16,8 @@
1717 'prefswitch-desc' => 'Allow users to swtich sets of preferences',
1818 'prefswitch-survey-true' => 'Yes',
1919 'prefswitch-survey-false' => 'No',
 20+ 'prefswitch-survey-submit-off' => 'Turn New Features Off',
 21+ 'prefswitch-survey-submit-feedback' => 'Send Feedback',
2022 'prefswitch-survey-question-likedislike' => 'What did you like about the new features? What did you dislike about the features?',
2123 'prefswitch-survey-question-whyoff' => 'Why are you turning off the new features? (Please select all that apply.)',
2224 'prefswitch-survey-answer-whyoff-hard' => 'It was too hard to use.',
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.php
@@ -59,8 +59,8 @@
6060 'submit-msg' => 'prefswitch-survey-submit-feedback',
6161 'updatable' => true,
6262 'questions' => array(
63 - 'feedback' => array(
64 - 'question' => 'prefswitch-survey-question-feedback',
 63+ 'likedislike' => array(
 64+ 'question' => 'prefswitch-survey-question-likedislike',
6565 'type' => 'text',
6666 ),
6767 'browser' => array(
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.css
@@ -3,6 +3,7 @@
44 margin-bottom: 1em;
55 }
66 form.prefswitch-survey {
 7+ width: 32em;
78 margin: 0;
89 padding: 0;
910 }
@@ -50,7 +51,9 @@
5152 padding: 0;
5253 line-height: 2em;
5354 }
54 -form.prefswitch-survey dl dt.prefswitch-survey-submit {
 55+form.prefswitch-survey .prefswitch-survey-submit {
 56+ margin-top: 1em;
 57+ margin-bottom: 1em;
5558 text-align: right;
5659 }
5760 form.prefswitch-survey input.prefswitch-need-other {
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php
@@ -207,7 +207,8 @@
208208 // Finish out the form
209209 $html .= Xml::openElement( 'dt', array( 'class' => 'prefswitch-survey-submit' ) );
210210 $html .= Xml::submitButton(
211 - wfMsg( $wgPrefSwitchSurveys[$mode]['submit-msg'] ), array( 'id' => 'prefswitch-survey-submit' )
 211+ wfMsg( $wgPrefSwitchSurveys[$mode]['submit-msg'] ),
 212+ array( 'id' => "prefswitch-survey-submit-{$mode}", 'class' => 'prefswitch-survey-submit' )
212213 );
213214 $html .= Xml::closeElement( 'dt' );
214215 $html .= Xml::closeElement( 'form' );

Status & tagging log