r64521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64520‎ | r64521 | r64522 >
Date:15:46, 2 April 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 19393) Feeds now format dates in user language rather than content language
There's no more need to do this with content language since the language code was added to the cache key in r58978.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/FeedUtils.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FeedUtils.php
@@ -86,7 +86,7 @@
8787 * @return String
8888 */
8989 public static function formatDiffRow( $title, $oldid, $newid, $timestamp, $comment, $actiontext='' ) {
90 - global $wgFeedDiffCutoff, $wgContLang, $wgUser;
 90+ global $wgFeedDiffCutoff, $wgLang, $wgUser;
9191 wfProfileIn( __METHOD__ );
9292
9393 $skin = $wgUser->getSkin();
@@ -108,9 +108,9 @@
109109 wfProfileIn( __METHOD__."-dodiff" );
110110
111111 #$diffText = $de->getDiff( wfMsg( 'revisionasof',
112 - # $wgContLang->timeanddate( $timestamp ),
113 - # $wgContLang->date( $timestamp ),
114 - # $wgContLang->time( $timestamp ) ),
 112+ # $wgLang->timeanddate( $timestamp ),
 113+ # $wgLang->date( $timestamp ),
 114+ # $wgLang->time( $timestamp ) ),
115115 # wfMsg( 'currentrev' ) );
116116
117117 // Don't bother generating the diff if we won't be able to show it
@@ -119,9 +119,9 @@
120120 $diffText = $de->getDiff(
121121 wfMsg( 'previousrevision' ), // hack
122122 wfMsg( 'revisionasof',
123 - $wgContLang->timeanddate( $timestamp ),
124 - $wgContLang->date( $timestamp ),
125 - $wgContLang->time( $timestamp ) ) );
 123+ $wgLang->timeanddate( $timestamp ),
 124+ $wgLang->date( $timestamp ),
 125+ $wgLang->time( $timestamp ) ) );
126126 }
127127
128128 if ( ( strlen( $diffText ) > $wgFeedDiffCutoff ) || ( $wgFeedDiffCutoff <= 0 ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -73,6 +73,8 @@
7474 * (bug 22935) image/x-ms-bmp mime type added for BMP files
7575 * (bug 23024) Special:ListFiles now escapes file names correctly
7676 * (bug 22867) "View source" tab is now only displayed if there's source text
 77+* (bug 19393) Feeds now format dates in user language rather than content
 78+ language
7779
7880 === API changes in 1.17 ===
7981 * (bug 22738) Allow filtering by action type on query=logevent

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58978(bug 19391) Fix caching for Recent ChangesFeed. Patch by Mormegil.btongminh22:13, 12 November 2009

Status & tagging log