r64504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64503‎ | r64504 | r64505 >
Date:21:22, 1 April 2010
Author:neilk
Status:deferred
Tags:
Comment:
layout of front page roughly correct now
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/mw.UploadWizard.js
@@ -10,6 +10,7 @@
1111 "mwe-upwiz-transported": "OK",
1212 "mwe-upwiz-click-here": "Click here to select a file",
1313 "mwe-upwiz-uploading": "uploading...",
 14+ "mwe-upwiz-editing": "editing...",
1415 "mwe-upwiz-remove-upload": "Remove this file from the list of files to upload",
1516 "mwe-upwiz-remove-description": "Remove this description",
1617 "mwe-upwiz-upload": "Upload",
@@ -73,8 +74,10 @@
7475
7576
7677
77 -mw.ProgressBar = function( selector ) {
 78+mw.ProgressBar = function( selector, text ) {
7879 var _this = this;
 80+ // XXX need to figure out a way to put something inside text.
 81+
7982 _this.progressBarDiv = $j('<div></div>')
8083 .addClass("mwe-upwiz-progress-bar")
8184 .progressbar( { value: 0 } );
@@ -88,6 +91,7 @@
8992 $j( selector ).html(
9093 $j('<div />').addClass( 'mwe-upwiz-progress' )
9194 .append( $j( '<div></div>' )
 95+ .addClass( 'mwe-upwiz-progress-bar-etr' )
9296 .append( _this.progressBarDiv )
9397 .append( _this.timeRemainingDiv ) )
9498 .append( $j( _this.countDiv ) )
@@ -128,9 +132,6 @@
129133 var _this = this;
130134
131135 _this.progressBarDiv.progressbar( 'value', parseInt( fraction * 100 ) );
132 - if (fraction > 0.5) {
133 - debugger;
134 - }
135136
136137 var remainingTime;
137138 if (_this.beginTime == null) {
@@ -1768,9 +1769,9 @@
17691770 + '<button id="mwe-upwiz-upload-ctrl" disabled="disabled">' + gM("mwe-upwiz-upload") + '</button>'
17701771 + '</div>'
17711772 + '</div>'
 1773+ + '<div id="mwe-upwiz-progress"></div>'
17721774 + '<div class="clearShim"></div>'
17731775 + '</div>'
1774 - + '<div id="mwe-upwiz-progress"></div>'
17751776 + '<div style="clear: left;"></div>'
17761777 + '</div>'
17771778 + '<div id="mwe-upwiz-tabdiv-details">'
@@ -1972,6 +1973,7 @@
19731974 progressProperty,
19741975 weightProperty,
19751976 progressBarSelector,
 1977+ progressBarText,
19761978 starter,
19771979 endCallback ) {
19781980
@@ -1983,7 +1985,7 @@
19841986 } );
19851987 var totalCount = wizard.uploads.length;
19861988
1987 - var progressBar = new mw.ProgressBar( progressBarSelector );
 1989+ var progressBar = new mw.ProgressBar( progressBarSelector, progressBarText );
19881990 progressBar.setTotal( totalCount );
19891991
19901992 transitioner = function() {
@@ -2046,6 +2048,7 @@
20472049 'transportProgress',
20482050 'transportWeight',
20492051 '#mwe-upwiz-progress',
 2052+ gM( 'mwe-upwiz-uploading' ),
20502053 function( upload ) {
20512054 upload.start();
20522055 },
@@ -2121,6 +2124,7 @@
21222125 'detailsProgress',
21232126 'detailsWeight',
21242127 '#mwe-upwiz-macro-progress',
 2128+ gM( 'mwe-upwiz-editing' ),
21252129 function( upload ) {
21262130 upload.details.submit();
21272131 },
Index: branches/js2-work/phase3/js/mwEmbed/modules/UploadWizard/css/uploadWizard.css
@@ -130,7 +130,7 @@
131131 border-bottom: 1px solid #e0e0e0;
132132 }
133133
134 -.mwe-upwiz-file-indicator {
 134+.mwe-upwiz-file-indicator, .mwe-upwiz-count {
135135 float: left;
136136 width: 92px;
137137 margin-left: 8px;
@@ -143,10 +143,13 @@
144144 margin-left: 4px;
145145 }
146146
147 -#mwe-upwiz-add-file-container.mwe-upwiz-add-files-n, .mwe-upwiz-visible-file {
 147+#mwe-upwiz-add-file-container.mwe-upwiz-add-files-n, .mwe-upwiz-visible-file, .mwe-upwiz-progress-bar-etr {
148148 width: 300px;
149149 height: 18px;
150150 padding-left: 5px;
 151+}
 152+
 153+#mwe-upwiz-add-file-container.mwe-upwiz-add-files-n, .mwe-upwiz-visible-file {
151154 float: left;
152155 }
153156
@@ -179,11 +182,11 @@
180183
181184
182185 #mwe-upwiz-files {
 186+ margin-left: 50px;
183187 margin-top: 20px;
184188 }
185189
186190 .mwe-upwiz-file {
187 - margin-left: 50px;
188191 width: 410px;
189192 }
190193
@@ -240,11 +243,15 @@
241244 color: #009900;
242245 }
243246
244 -.mwe-upwiz-progress-bar {
245 - margin-left: 50px;
 247+.mwe-upwiz-progress-bar-etr {
 248+ float: left;
246249 }
247250
 251+.mwe-upwiz-etr {
 252+ text-align: center;
 253+}
248254
 255+
249256 .mwe-upwiz-upload-warning {
250257 background: #ffffe0;
251258 }

Status & tagging log