r64494 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64493‎ | r64494 | r64495 >
Date:18:22, 1 April 2010
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Better RELEASE-NOTES for r64228

It was deliberate that blocked users could unblock themselves, so not a
bug. Also improve wording in light of r64231, so it's clear that admins
still have this ability by default.

(Apparently forgot to commit this until now.)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
——@@ -35,6 +35,8 @@
3636 * Future-proof redirection to fragments in Gecko, so things work a little nicer
3737 if they fix <https://bugzilla.mozilla.org/show_bug.cgi?id=516293>.
3838 * Support git:// and mms:// protocols by default for external links
 39+* (bug 15810) Blocked admins can no longer block/unblock anyone without the
 40+ 'unblockself' permission (which they have by default).
3941
4042 === Bug fixes in 1.17 ===
4143 * (bug 17560) Half-broken deletion moved image files to deletion archive without
——@@ -58,8 +60,6 @@
5961 * (bug 22903) Revdelete log entries now show in the user preferred language.
6062 * (bug 22905) Correctly handle <abbr> followed by ISBN
6163 * (bug 22940) Namespace aliases pointing to main namespace don't work
62 -* (bug 15810) blocked admins can no longer block/unblock other users, nor
63 - themselves unless they are given the 'unblockself' permission.
6464 * (bug 22876) Avoid possible PHP Notice if $wgDefaultUserOptions is not
6565 correctly set
6666 * (bug 14952) Page titles are renormalized after html entities are removed so that

Follow-up revisions

RevisionCommit summaryAuthorDate
r64496Better better RELEASE-NOTES for r64228...simetrical19:43, 1 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64228(bug 15810) stop blocked admins from unblocking themselves or others.happy-melon22:02, 26 March 2010
r64231Follow-up r64228, per requests at bug 15810: grant admins 'unblockself' by de...happy-melon23:11, 26 March 2010

Comments

#Comment by Happy-melon (talk | contribs)   19:06, 1 April 2010

I'm not convinced that this is an improvement. It's no longer clear that blocked admins are always now unable to block/unblock other users, and that unblockself only allows them to change their own block status. IMO blocked-admin-can-still-block-other-people was always a bug; only the blocked-admin-can-unblock-self is a feature.

#Comment by Simetrical (talk | contribs)   19:46, 1 April 2010

It's no longer clear because I misunderstood.  :) I've updated it in r64496 to reflect that there's a new feature *and* a bug fix. I'm not sure I like the new wording for the feature part, but at least it makes it clear that it's true by default.

Status & tagging log