r64458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64457‎ | r64458 | r64459 >
Date:22:17, 31 March 2010
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed double border render error when a search suggestion had only the "containing" area visible.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/suggestions.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -18,7 +18,7 @@
1919 private static $styleFiles = array(
2020 'base_sets' => array(
2121 'raw' => array(
22 - array( 'src' => 'css/suggestions.css', 'version' => 8 ),
 22+ array( 'src' => 'css/suggestions.css', 'version' => 9 ),
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 7 ),
2424 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 1 ),
2525 array( 'src' => 'css/wikiEditor.css', 'version' => 12 ),
@@ -29,11 +29,11 @@
3030 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3131 ),
3232 'combined' => array(
33 - array( 'src' => 'css/combined.css', 'version' => 83 ),
 33+ array( 'src' => 'css/combined.css', 'version' => 84 ),
3434 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3535 ),
3636 'minified' => array(
37 - array( 'src' => 'css/combined.min.css', 'version' => 83 ),
 37+ array( 'src' => 'css/combined.min.css', 'version' => 84 ),
3838 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3939 ),
4040 )
Index: trunk/extensions/UsabilityInitiative/css/suggestions.css
@@ -23,6 +23,7 @@
2424 display: none;
2525 padding: 0.25em 0.25em;
2626 line-height: 1.25em;
 27+ margin-top: -1px;
2728 }
2829 .suggestions-special:hover {
2930 background-color: #4C59A6;
@@ -39,8 +40,10 @@
4041 font-size: 0.8em;
4142 cursor: pointer;
4243 border: solid 1px #aaaaaa;
 44+ border-top-width: 0;
4345 padding: 0;
4446 margin: 0;
 47+ margin-top: 1px;
4548 }
4649 .suggestions-result {
4750 color: black;
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -23,6 +23,7 @@
2424 display: none;
2525 padding: 0.25em 0.25em;
2626 line-height: 1.25em;
 27+ margin-top: -1px;
2728 }
2829 .suggestions-special:hover {
2930 background-color: #4C59A6;
@@ -39,8 +40,10 @@
4041 font-size: 0.8em;
4142 cursor: pointer;
4243 border: solid 1px #aaaaaa;
 44+ border-top-width: 0;
4345 padding: 0;
4446 margin: 0;
 47+ margin-top: 1px;
4548 }
4649 .suggestions-result {
4750 color: black;
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -21,6 +21,7 @@
2222 display:none;
2323 padding:0.25em 0.25em;
2424 line-height:1.25em;
 25+margin-top:-1px;
2526 }
2627 .suggestions-special:hover{
2728 background-color:#4C59A6;
@@ -37,8 +38,10 @@
3839 font-size:0.8em;
3940 cursor:pointer;
4041 border:solid 1px #aaaaaa;
 42+border-top-width:0;
4143 padding:0;
4244 margin:0;
 45+margin-top:1px;
4346 }
4447 .suggestions-result{
4548 color:black;

Status & tagging log