r64430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64429‎ | r64430 | r64431 >
Date:07:24, 31 March 2010
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
Follow up to r64427
Modified paths:
  • /trunk/extensions/Maps/Geocoders/Maps_BaseGeocoder.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Geocoders/Maps_BaseGeocoder.php
——@@ -22,7 +22,7 @@
2323 *
2424 * @param string $address
2525 */
26 - public abstract static function geocode( $address );
 26+ public abstract function geocode( $address );
2727
2828 /**
2929 * Returns the content of the requested file, or false when the connection fails

Follow-up revisions

RevisionCommit summaryAuthorDate
r64431Follow up to r64430jeroendedauw07:55, 31 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64427Changes for 0.6 - follow up on r64422 - Fixed some issuesjeroendedauw07:11, 31 March 2010

Comments

#Comment by Raymond (talk | contribs)   07:26, 31 March 2010

PHP Fatal error: Cannot make non static method MapsBaseGeocoder::geocode() static in class MapsGoogleGeocoder in /www/w/extensions/Maps/Geocoders/Maps_GoogleGeocoder.php on line 22

#Comment by Jeroen De Dauw (talk | contribs)   07:51, 31 March 2010

Oh man, why does PHP have to be so lame >_>. I'll make a follow up commit in a few mins.

Status & tagging log