r64333 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64332‎ | r64333 | r64334 >
Date:12:48, 29 March 2010
Author:demon
Status:ok
Tags:
Comment:
Move global debugging hacks to entry point with other global overrides.
Modified paths:
  • /branches/new-installer/phase3/config/new-index.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -77,10 +77,6 @@
7878 * @return array New session array
7979 */
8080 function execute( $session ) {
81 - //@todo decide if we really need this error handling
82 - global $wgShowSQLErrors, $wgShowExceptionDetails, $wgShowDBErrorBacktrace;
83 - $wgShowSQLErrors = $wgShowExceptionDetails = $wgShowDBErrorBacktrace = true;
84 -
8581 $this->session = $session;
8682 if ( isset( $session['settings'] ) ) {
8783 $this->settings = $session['settings'] + $this->settings;
Index: branches/new-installer/phase3/config/new-index.php
@@ -11,6 +11,10 @@
1212 $GLOBALS['wgShowExceptionDetails'] = true;
1313 // Don't break forms
1414 $GLOBALS['wgExternalLinkTarget'] = '_blank';
 15+
 16+ // Extended debugging. Maybe disable before release?
 17+ $GLOBALS['wgShowSQLErrors'] = true;
 18+ $GLOBALS['wgShowDBErrorBacktrace'] = true;
1519 }
1620
1721 chdir( ".." );

Status & tagging log