r64321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64320‎ | r64321 | r64322 >
Date:22:49, 28 March 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6 - Bunch of bug fixes
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_MapPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsQP.php
@@ -67,13 +67,11 @@
6868 wfMsg('maps-loading-map')
6969 );
7070
71 - $layerItems = MapsOpenLayers::createLayersStringAndLoadDependencies( $this->output, $this->layers );
72 -
7371 $parser->getOutput()->addHeadItem(
7472 Html::inlineScript( <<<EOT
7573 addOnloadHook(
7674 function() {
77 - initOpenLayer(
 75+ initializeYahooMap(
7876 '$this->mapName',
7977 $this->centre_lat,
8078 $this->centre_lon,
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_MapPrinter.php
@@ -94,7 +94,8 @@
9595
9696 $this->setCentre();
9797
98 - $this->addSpecificMapHTML();
 98+ global $wgParser;
 99+ $this->addSpecificMapHTML( $wgParser );
99100 }
100101 else {
101102 // TODO: add warning when level high enough and append to error list?
@@ -239,8 +240,8 @@
240241 // TODO: add escaping to title and label (they are getting escaped now on some place where they shouldn't)
241242 Xml::escapeJsString( $lat ),
242243 Xml::escapeJsString( $lon ),
243 - $title,
244 - $text,
 244+ Xml::escapeJsString( $title ),
 245+ Xml::escapeJsString( $text ),
245246 Xml::escapeJsString( $icon )
246247 );
247248 }
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php
@@ -92,8 +92,6 @@
9393 function() {
9494 initializeGoogleMap('$this->mapName',
9595 {
96 - width: $this->width,
97 - height: $this->height,
9896 lat: $this->centre_lat,
9997 lon: $this->centre_lon,
10098 zoom: $this->zoom,

Status & tagging log