r64318 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64317‎ | r64318 | r64319 >
Date:22:18, 28 March 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6 - Removed redudant vars and changed the values of the Maps_COORD enum
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispMap.php (modified) (history)
  • /trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispPoint.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/OpenLayers/Maps_OpenLayersDispMap.php (modified) (history)
  • /trunk/extensions/Maps/OpenLayers/Maps_OpenLayersDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/OpenStreetMap/Maps_OSMDispMap.php (modified) (history)
  • /trunk/extensions/Maps/OpenStreetMap/Maps_OSMDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispPoint.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispPoint.php
@@ -58,8 +58,6 @@
5959 *
6060 */
6161 public function addSpecificMapHTML() {
62 - global $wgOut;
63 -
6462 $this->output .= Html::element(
6563 'div',
6664 array(
Index: trunk/extensions/Maps/GoogleMaps3/Maps_GoogleMaps3DispMap.php
@@ -56,8 +56,6 @@
5757 *
5858 */
5959 public function addSpecificMapHTML() {
60 - global $wgOut;
61 -
6260 $this->output .= Html::element(
6361 'div',
6462 array(
Index: trunk/extensions/Maps/OpenLayers/Maps_OpenLayersDispPoint.php
@@ -53,8 +53,6 @@
5454 *
5555 */
5656 public function addSpecificMapHTML( Parser $parser ) {
57 - global $wgOut;
58 -
5957 $layerItems = MapsOpenLayers::createLayersStringAndLoadDependencies( $this->output, $this->layers );
6058
6159 $this->output .= Html::element(
Index: trunk/extensions/Maps/OpenLayers/Maps_OpenLayersDispMap.php
@@ -46,8 +46,6 @@
4747 *
4848 */
4949 public function addSpecificMapHTML( Parser $parser ) {
50 - global $wgOut;
51 -
5250 $layerItems = MapsOpenLayers::createLayersStringAndLoadDependencies( $this->output, $this->layers );
5351
5452 $this->output .= Html::element(
Index: trunk/extensions/Maps/Maps.php
@@ -33,13 +33,13 @@
3434 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3535 }
3636 else {
37 - define( 'Maps_VERSION', '0.6 a4' );
 37+ define( 'Maps_VERSION', '0.6 a5' );
3838
3939 // The different coordinate notations.
40 - define( 'Maps_COORDS_FLOAT', 0 );
41 - define( 'Maps_COORDS_DMS', 1 );
42 - define( 'Maps_COORDS_DM', 2 );
43 - define( 'Maps_COORDS_DD', 3 );
 40+ define( 'Maps_COORDS_FLOAT', 'float' );
 41+ define( 'Maps_COORDS_DMS', 'dms' );
 42+ define( 'Maps_COORDS_DM', 'dm' );
 43+ define( 'Maps_COORDS_DD', 'dd' );
4444
4545 // The symbols to use for degrees, minutes and seconds.
4646 define( 'Maps_GEO_DEG', "°" );
Index: trunk/extensions/Maps/OpenStreetMap/Maps_OSMDispMap.php
@@ -67,8 +67,6 @@
6868 *
6969 */
7070 public function addSpecificMapHTML( Parser $parser ) {
71 - global $wgOut;
72 -
7371 $parser->getOutput()->addHeadItem(
7472 Html::inlineScript( <<<EOT
7573 addOnloadHook(
Index: trunk/extensions/Maps/OpenStreetMap/Maps_OSMDispPoint.php
@@ -53,8 +53,6 @@
5454 *
5555 */
5656 public function addSpecificMapHTML( Parser $parser ) {
57 - global $wgOut;
58 -
5957 $parser->getOutput()->addHeadItem(
6058 Html::inlineScript( <<<EOT
6159 addOnloadHook(
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispMap.php
@@ -63,8 +63,6 @@
6464 *
6565 */
6666 public function addSpecificMapHTML( Parser $parser ) {
67 - global $wgOut;
68 -
6967 MapsGoogleMaps::addOverlayOutput( $this->output, $this->mapName, $this->overlays, $this->controls );
7068
7169 $this->output .= Html::element(
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsDispPoint.php
@@ -65,8 +65,6 @@
6666 *
6767 */
6868 public function addSpecificMapHTML( Parser $parser ) {
69 - global $wgOut;
70 -
7169 MapsGoogleMaps::addOverlayOutput( $this->output, $this->mapName, $this->overlays, $this->controls );
7270
7371 $this->output .= Html::element(
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispPoint.php
@@ -53,8 +53,6 @@
5454 *
5555 */
5656 public function addSpecificMapHTML( Parser $parser ) {
57 - global $wgOut;
58 -
5957 $this->output .= Html::element(
6058 'div',
6159 array(
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMapsDispMap.php
@@ -46,8 +46,6 @@
4747 *
4848 */
4949 public function addSpecificMapHTML( Parser $parser ) {
50 - global $wgOut;
51 -
5250 $this->output .= Html::element(
5351 'div',
5452 array(

Status & tagging log