r64297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64296‎ | r64297 | r64298 >
Date:17:23, 28 March 2010
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile: some E_NOTICE fixes
Modified paths:
  • /trunk/extensions/SocialProfile/UserStats/TopFansRecent.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserStats/TopFansRecent.php
@@ -31,7 +31,7 @@
3232 $period = 'monthly';
3333 }
3434
35 - if ( !$period ) {
 35+ if ( !isset( $period ) ) {
3636 $period = 'weekly';
3737 }
3838
@@ -79,7 +79,7 @@
8080 $top_title = SpecialPage::getTitleFor( 'TopUsers' );
8181 $recent_title = SpecialPage::getTitleFor( 'TopUsersRecent' );
8282
83 - $out .= '<div class="top-fan-nav">
 83+ $out = '<div class="top-fan-nav">
8484 <h1>' . wfMsg( 'top-fans-by-points-nav-header' ) . '</h1>
8585 <p><a href="' . $top_title->escapeFullURL() . '">' . wfMsg( 'top-fans-total-points-link' ) . '</a></p>';
8686

Status & tagging log